Last modified: 2014-10-20 00:02:47 UTC
See https://github.com/facebook/hhvm/issues/2829.
*** Bug 68261 has been marked as a duplicate of this bug. ***
This is being fixed by https://github.com/facebook/hhvm/pull/3249
When do we expect to land this in the Travis hhvm-nightly? Our tests [0] running on HipHop VM 3.3.0-dev+2014.07.23 (rel) still fail for the import part! [0] https://travis-ci.org/SemanticMediaWiki/SemanticMediaWiki/jobs/30805643
I'm debugging an issue with it right now. I'm hoping to have it cleaned up and committed by Monday, so it should be in the next nightly after that.
(In reply to Brett Simmers from comment #4) > I'm debugging an issue with it right now. I'm hoping to have it cleaned up > and committed by Monday, so it should be in the next nightly after that. [0] uses HipHop VM 3.3.0-dev+2014.08.10 (rel) Compiler: heads/master-0-g2060b3a6a9f59cd5bf7bf5023e64ca9e793d04e3 and allowed the remaining failed import tests to run successfully on MW master / SQLite / PHPUnit 4.1.5. [0] https://travis-ci.org/SemanticMediaWiki/SemanticMediaWiki/jobs/32143305
*** Bug 70658 has been marked as a duplicate of this bug. ***
The HHVM patch was merged some weeks ago. Apparently WMF is using HHVM version "3.3.0-dev (srv)", which is pretty meaningless as version numbers go. It appears to me that if/when we upgrade to a "newer" HHVM 3.3.0, we'll get the benefit of this patch.
via a few emails, giuseppe pointed out that the current wm hhvm: HipHop VM 3.3.0-dev (rel) Compiler: heads/master-0-g2e297ed662d6cec9368ab8bd527ac06eaeef18cc Repo schema: 4cd91499a6638cdf8f21e85093dc7dab65e909e0 Extension API: 20140727 contains these patches: https://github.com/wikimedia/operations-debs-hhvm/blob/master/debian/patches/series which contain the patch mentioned above: https://bugzilla.wikimedia.org/show_bug.cgi?id=66023#c2 specifically in this patch: https://github.com/wikimedia/operations-debs-hhvm/blob/master/debian/patches/Support-stream-wrappers-in-XML-parser-extensions-add-external-entity-loader.patch yet, the issue continues with Special:Import. i think, but haven’t been able to verify yet, that the issue is with the custom stream that is created in Import.php using "uploadsource://$id".
https://gerrit.wikimedia.org/r/#/c/159973/
Change 159973 had a related patch set uploaded by Dan-nl: Special:Import not importing Special:Export XMLs https://gerrit.wikimedia.org/r/159973
https://github.com/facebook/hhvm/pull/3840
Change 162818 had a related patch set uploaded by Dan-nl: Special:Import not importing Special:Export XMLs https://gerrit.wikimedia.org/r/162818
Change 159973 abandoned by Dan-nl: Special:Import not importing Special:Export XMLs Reason: since a solution in hhvm was found, as ori mentioned above, i'll abandon this patch. the extracted unit test is available separately in I446f57c1 if you wish to consider adding it. https://gerrit.wikimedia.org/r/159973
