Last modified: 2014-10-20 22:40:36 UTC
This is related to Bug 67153, but specific to Safari: Whatever the dialog box, once you've tabbed through whatever links and buttons are inside that dialog (and on the tab list, which isn't always all of them), then pressing tab takes you outside the dialog box to these items: 1) the browser's URL bar 2) the main Wikipedia search box 3) the Cancel button (on VisualEditor's toolbar) 4) the Save button (on VisualEditor's toolbar) 5) the top of the article 6) the slug at the top of the article, where it gets stuck forever. and never lets you get back to the dialog box. This means that if you press tab one time more than you meant to, you cannot use or close the dialog box without taking your hands off the keyboard.
Krenair, is this something that we do as part of the aria-role stuff (and is it something we should do)?
I don't think we do this deliberately. This happens in Chrome for me... Are you sure this is Safari-specific, Sherry?
Firefox lets me leave the dialog box, but it eventually tabs back into it. Safari gets stuck. I haven't checked Chrome; Safari and Chrome often have the same problems, so it might be anything WebKit/not Mozilla.
In that case this feels like an upstream issue
So after some confusion about this I looked into it again, and I believe that there's two issues here: * We perhaps shouldn't let tab take the focus out of the dialog box at all * Tab definitely should not be getting lost and become unable to return to the dialog Different browsers appear to do different things: * Chrome on Ubuntu lets it out of the dialog, but it properly goes back and doesn't get stuck. * Chrome and Safari on Windows just let the tabbing leave the dialog, and then it gets stuck and doesn't return to the beginning of the page * Firefox (on Ubuntu or Windows) does not let it out of the dialog
Change 159902 had a related patch set uploaded by Alex Monk: Try to stop user from tabbing outside of open dialog box https://gerrit.wikimedia.org/r/159902
Change 159902 merged by jenkins-bot: Try to stop user from tabbing outside of open dialog box https://gerrit.wikimedia.org/r/159902
Merged. Hopefully this doesn't break anything else.
The applied patch throws an exception, see gerrit.
