Last modified: 2014-08-25 12:04:38 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T68520, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 66520 - JQMIGRATE: jQuery.fn.andSelf() replaced by jQuery.fn.addBack()
JQMIGRATE: jQuery.fn.andSelf() replaced by jQuery.fn.addBack()
Status: RESOLVED WORKSFORME
Product: Wikimedia
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Low minor (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: jqmigrate
  Show dependency treegraph
 
Reported: 2014-06-12 09:08 UTC by Lokal_Profil
Modified: 2014-08-25 12:04 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Lokal_Profil 2014-06-12 09:08:38 UTC
Triggered when clicking on "add links" for adding iw links to a new article (i.e. one without an exisiting Wikidata entry). Clicing the link triggers a pop-up and also the JQMIGRATE warning

"JQMIGRATE: jQuery.fn.andSelf() replaced by jQuery.fn.addBack()" load.php:10350
console.trace(): load.php:10352
migrateWarn() load.php:10352
jQuery.fn.andSelf() load.php:10640
visible() jquery.ui.core.js:204
focusable() jquery.ui.core.js:200
.tabbable() jquery.ui.core.js:229
elementMatcher/<() load.php:2160
matcherFromGroupMatchers/superMatcher() load.php:2375
Sizzle</Sizzle.select() load.php:2550
Sizzle() load.php:879
.find() load.php:2704
.open() jquery.ui.dialog.js:343
._init() jquery.ui.dialog.js:199
$.Widget.prototype._createWidget() jquery.ui.widget.js:168
$.widget/$[namespace][name]() jquery.ui.widget.js:63
$.widget.bridge/$.fn[name]/<() jquery.ui.widget.js:129
.each() load.php:383
jQuery.prototype.each() load.php:136
$.widget.bridge/$.fn[name]() jquery.ui.widget.js:124
._createDialog() jquery.wikibase.linkitem.js:176
._create/<() jquery.wikibase.linkitem.js:116
jQuery.Callbacks/fire() load.php:3119
jQuery.Callbacks/self.fireWith() load.php:3231
.Deferred/</deferred[tuple[0]]() load.php:3321
mw.Api.prototype.ajax/xhr<() mediawiki.api.js:222
jQuery.Callbacks/fire() load.php:3119
jQuery.Callbacks/self.fireWith() load.php:3231
done() load.php:9275
.send/callback() load.php:9685
Comment 1 Lokal_Profil 2014-06-12 09:15:28 UTC
Note that this function (i.e. link appearing) only seems to work consistently in Firefox (separate bugg for that) and that clicking the link additionally throws a "JQMIGRATE: jQuery.browser is deprecated" warning.

Example page: https://sv.wikipedia.org/w/index.php?title=Marta_von_Fieandt-Björkman&uselang=en
Comment 2 Andre Klapper 2014-06-12 10:34:29 UTC
Which exact file is jQuery.fn.andSelf() loaded from? (attaching a debug=true parameter to the URL should provide more info in the browser error console)
Comment 3 Lokal_Profil 2014-06-12 14:35:39 UTC
Sadly the above trace is the same as that for debug=true in firefox. 

Line 204 in jquery.ui.core.js seems to contain the following though

function visible( element ) {
	return !$( element ).parents().andSelf().filter(function() {
		return $.curCSS( this, "visibility" ) === "hidden" ||
			$.expr.filters.hidden( this );
	}).length;
}
Comment 4 Krinkle 2014-08-25 12:04:38 UTC
Closing as WORKSFORME. See also bug 69350.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links