Last modified: 2014-08-25 11:59:28 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T71350, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 69350 - WikiLove: Fix "JQMIGRATE: jQuery.fn.andSelf() replaced by jQuery.fn.addBack()"


Summary:	WikiLove: Fix "JQMIGRATE: jQuery.fn.andSelf() replaced by jQuery.fn.addBack()"

Status:	RESOLVED WORKSFORME

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	WikiLove (Other open bugs)
Version:	master
Hardware:	All All

Importance:	Normal normal (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	jqmigrate
	Show dependency tree / graph

Reported:	2014-08-09 18:24 UTC by Helder
Modified:	2014-08-25 11:59 UTC (History)
CC List:	7 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Helder 2014-08-09 18:24:48 UTC

When I click on Wikilove icon I get
"JQMIGRATE: jQuery.fn.andSelf() replaced by jQuery.fn.addBack()"
in the console. This comes from jquery.ui 1.9.2:
https://github.com/wikimedia/mediawiki-core/blob/master/resources/lib/jquery.ui/jquery.ui.core.js#L155
!$( element ).parents().andSelf().filter(function() {

Comment 1 Ryan Kaldari 2014-08-11 07:14:55 UTC

The newer versions of jQuery UI use addBack() instead of andSelf(), otherwise the function is identical.

Comment 2 Krinkle 2014-08-25 11:59:17 UTC

jQuery Migrate's warning about andSelf() is a bit early. It was *not* removed in jQuery 1.8 or any other version. It is still supported in jQuery 1.11 (latest) and 2.x.

So this isn't a perquisite for the current migration cycle of jQuery. jQuery UI chooses to continue using andSelf instead of addBack so that it is compatible with both old and new jQuery versions. If and when jQuery core removes andSelf, jQuery UI will likely use feature detection and thus no longer trigger this warning.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links