Last modified: 2014-05-17 14:17:10 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T67013, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 65013 - Test QueryGenerator.limit
Test QueryGenerator.limit
Status: RESOLVED FIXED
Product: Pywikibot
Classification: Unclassified
General (Other open bugs)
core-(2.0)
All All
: Unprioritized normal
: ---
Assigned To: Pywikipedia bugs
:
Depends on:
Blocks: 58941 64489
  Show dependency tree / graph
 
Reported: 2014-05-07 19:03 UTC by Merlijn van Deen (test)
Modified: 2014-05-17 14:17 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Merlijn van Deen (test) 2014-05-07 19:03:47 UTC 
Test various values, including:

0,1,many,
-1, -somethingelse,
None (should probably throw a warning given it's not actually an allowed value)

See https://gerrit.wikimedia.org/r/#/c/131991/ for more details.
Comment 1 xqt 2014-05-07 19:12:16 UTC 
Some additional hints

Look at Site.preloadpages() method at site.py line 1381
QueryGenerator.limit is set to -1:

rvgen.set_maximum_items(-1)  # suppress use of "rvlimit" parameter

Documentation of QueryGenerator.set_maximum_items() Shows
"""
        If set to -1 (or any negative value), the "limit" parameter will be
        omitted from the request. For some request types (such as
        prop=revisions), this is necessary to signal that only current
        revision is to be returned.
"""
Comment 2 Gerrit Notification Bot 2014-05-09 11:22:01 UTC 
Change 132387 had a related patch set uploaded by Xqt:
(bug 65013) Test QueryGenerator.limit

https://gerrit.wikimedia.org/r/132387
Comment 3 Gerrit Notification Bot 2014-05-17 13:03:45 UTC 
Change 132387 merged by jenkins-bot:
(bug 65013) Test QueryGenerator.limit

https://gerrit.wikimedia.org/r/132387
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links