Last modified: 2014-08-31 00:40:37 UTC
Two minor fixes for the Typography refresh: * <dd>, <ol> and <ul> have their line-height set to 1.5em in commonElements.css; these must be set to inherit in common.less. * H1 has no top margin in the body, causing it to stick to content directly above it. Set to 1em for H1, and to 0 for #firstHeading. I would *like* to increase H3 fontsize from 1.17em to 1.2em, as it is too close in size to body text. Are there and objections to this? Patch is in the works, but I need to know about H3 before I submit it.
Typography folks: Could somebody please provide feedback on h3 size to Erwin?
Hey Erwin thanks for raising these issues - a few clarifications! * In terms of line height - why do they need to be inherit? What problem does this cause? * In terms of the H1 having no top margin can you submit a screenshot showing where this becomes a problem? I see there is top padding on #content so I'm not sure why this would be a problem and I'm worried increasing this gap with a top margin would be weird. * In terms of h3 font size I can always review it with the designers and point out the changes. <aybe submit the patch anyway?
Hi Jon, * Currently, line-height is set to 1.5em for <dd>, <ol> and <ul> in commonElements.css. This overrides the 1.6em from the typography refresh, which causes inconsistent line heights on talk pages. They will need to match (not inherit, strike that). * See https://www.mediawiki.org/wiki/User:Edokter/sandbox#A_H1_header I'm not looking to change the title H1, just add the margin to H1 inside bodyContent to match H2. * I'll submit it tomorrow.
Oh I see! Yeh this doesn't seem like a problem provided it doesn't touch the top margin of the firstHeading! Thanks :)
Added issue: diff lineheight, for which a patch is waiting review: https://gerrit.wikimedia.org/r/133978/ Will submit patch for other issues later.
Change 133978 had a related patch set uploaded by Jdlrobson: Apply correct line-height to diffs https://gerrit.wikimedia.org/r/133978
Change 133978 merged by jenkins-bot: Apply correct line-height to diffs https://gerrit.wikimedia.org/r/133978
Patch was merged, so resetting bug status to NEW.
