Last modified: 2014-04-10 15:56:34 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T65731, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 63731 - Typography refresh - body line-height is applied to wrong ID
Typography refresh - body line-height is applied to wrong ID
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
1.23.0
All All
: Unprioritized normal (vote)
: 1.23.0 release
Assigned To: Erwin Dokter
:
Depends on:
Blocks: typography-refresh
  Show dependency treegraph
 
Reported: 2014-04-09 15:24 UTC by Erwin Dokter
Modified: 2014-04-10 15:56 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Erwin Dokter 2014-04-09 15:24:25 UTC
The 1.6 line-height (set in variables.less) in the Typography Refresh has been applied to div#content, which is in turn overridden by the 1.5em line-height of #bodyContent (set in common.less).

Fix: Remove line-height rule for div#content and set line-height for #bodyContent to @content-line-height.

Patch in Gerrit shortly.
Comment 1 Gerrit Notification Bot 2014-04-09 15:33:14 UTC
Change 124866 had a related patch set uploaded by Gerrit Patch Uploader:
Typograhy Refresh - Apply line-height to correct ID

https://gerrit.wikimedia.org/r/124866
Comment 2 Gerrit Notification Bot 2014-04-10 00:22:48 UTC
Change 124866 merged by jenkins-bot:
Typography Refresh - Apply line-height to correct ID

https://gerrit.wikimedia.org/r/124866
Comment 3 Bartosz Dziewoński 2014-04-10 15:56:34 UTC
I assume this is fixed now.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links