Last modified: 2014-04-18 19:38:26 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 63408 - Re-consider font size and font-family for form elements in Vector
Re-consider font size and font-family for form elements in Vector
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
UploadWizard (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on: 63887
Blocks: typography-refresh
  Show dependency treegraph
 
Reported: 2014-04-02 11:19 UTC by Rainer Rillke @commons.wikimedia
Modified: 2014-04-18 19:38 UTC (History)
13 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
screenshot using firefox on windows showing upload wizard form inputs with font-sizes annotated (20.23 KB, image/png)
2014-04-02 11:19 UTC, Rainer Rillke @commons.wikimedia
Details
more drastically on ff/linux (20.17 KB, image/png)
2014-04-02 11:23 UTC, Rainer Rillke @commons.wikimedia
Details

Description Rainer Rillke @commons.wikimedia 2014-04-02 11:19:41 UTC
Created attachment 15003 [details]
screenshot using firefox on windows showing upload wizard form inputs with font-sizes annotated

Currently, Upload Wizard defines font-family: sans-serif for most of its form elements. After the "typographical refresh", this, together with the slightly smaller font-family, produces a misaligned output.

https://commons.wikimedia.org/w/index.php?title=Commons%3AVillage_pump&diff=120509714&oldid=120505191
Comment 1 Rainer Rillke @commons.wikimedia 2014-04-02 11:23:57 UTC
Created attachment 15004 [details]
more drastically on ff/linux
Comment 2 Andre Klapper 2014-04-02 12:01:13 UTC
Thanks for taking the time to report this!

How does this create an accessibility problem (anybody could increase the font size in th browser)?
Comment 3 Rainer Rillke @commons.wikimedia 2014-04-02 12:09:43 UTC
(In reply to Andre Klapper from comment #2)
> anybody could increase the font size in th browser

The aim of the "typographical refresh" refresh update was I think to not have people to fiddle around with their browser settings.
Comment 4 Rainer Rillke @commons.wikimedia 2014-04-02 19:16:41 UTC
yeah, form elements do not inherit font family from their offset parents, so you may start a separate bug for this, as if you like to add something similar to

input,select,textarea { font-family:inherit; font-size:inherit; }

but note that UpWiz explicitly defines sans-serif for some classes used on input elements in it.
Comment 5 Steinsplitter 2014-04-04 09:33:43 UTC
It is fiexed now? It looks like no?
@Rillke: I guess we can fix this in the global .ccs?
Comment 6 Rainer Rillke @commons.wikimedia 2014-04-04 20:14:24 UTC
(In reply to Steinsplitter from comment #5)
Why is this a major issue? The text is still readable by most people. Or does it even look worse for you than the screenshots I attached?

Yes, we could attempt to "fix" it but applying extra-css often causes many side effects and I'd really like to see it fixed by someone running browser tests before or having a very good understanding of what could happen. Leaving the side effects aside, there is still the maintenance issue. The code we have must be probably be updated if the TypoRefresh updates. No, please let users complain and nag here instead.
Comment 7 Jared Zimmerman (WMF) 2014-04-09 18:49:25 UTC
Sounds like the fix for this is removing extra overrides from this form.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links