Last modified: 2014-03-25 02:05:44 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T65053, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 63053 - UploadWizard CSS is loaded twice
UploadWizard CSS is loaded twice
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
UploadWizard (Other open bugs)
master
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-03-25 02:00 UTC by Matthew Flaschen
Modified: 2014-03-25 02:05 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Matthew Flaschen 2014-03-25 02:00:58 UTC
Due to 0a1a638553579d4effda75dc3c8f6e75aed97e15 (which was apparently intended to fix a FUOC), the styles are now loaded twice (once via the JavaScript ResourceLoader loader, and another time via addModuleStyles).

I think the correct solution is to make a separate module for styles that apply to HTML delivered from the server, and load that in the top queue.  These styles should then be removed from the main module.

This top queue module could use addModuleStyles so at least the error text renders right if the browser doesn't have JavaScript.
Comment 1 Matthew Flaschen 2014-03-25 02:05:44 UTC
(In reply to Matthew Flaschen from comment #0)
> This top queue module could use addModuleStyles so at least the error text
> renders right if the browser doesn't have JavaScript.

It doesn't look like UploadWizard has any custom error styles.  This might not be an issue, in which case they could both use addModules, with one just having 'position' => 'top'.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links