Last modified: 2014-03-25 02:02:06 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 34601 - "Drop media file to donate here" sometimes silently fails
"Drop media file to donate here" sometimes silently fails
Product: MediaWiki extensions
Classification: Unclassified
UploadWizard (Other open bugs)
All All
: High major (vote)
: MW 1.19 version
Assigned To: Brion Vibber
Depends on:
Blocks: 31217
  Show dependency treegraph
Reported: 2012-02-22 22:36 UTC by Rob Lanphier
Modified: 2014-03-25 02:02 UTC (History)
3 users (show)

See Also:
Web browser: Google Chrome
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Description Rob Lanphier 2012-02-22 22:36:48 UTC
The "Drop media file to donate here" button (second screen of the UploadWizard) will sometimes fail to bring up the file dialog (in Chrome; possibly other browsers)

1.  Visit
2.  (optional) check "Skip tutorial"
3.  Click "Drop media file to donate here"
4.  (if necessary) Shift-reload and repeat

Eventually, when you click, it won't come up.
Comment 1 Brion Vibber 2012-02-22 23:14:03 UTC
Ok, managed to repro this -- looking into it now...
Comment 2 Brion Vibber 2012-02-23 00:06:10 UTC
r112166 seems to reduce it but not eliminate it entirely -- adds a second ping to moveFileInputToCover() 50ms after the first one.

It seems that the error in positioning happens mostly when the styles haven't been applied yet when we start creating the UI; a visibile flash of text from the learn/upload/release/etc step list shows, then things move into their final positions... but the file input has been positioned relative to something else and no longer fits over the button.
Comment 3 Rob Lanphier 2012-02-23 01:26:39 UTC
Thanks for looking at this one Brion.  I tried this 20 times, and it failed once, which isn't great, but I'm pretty sure is much better than before.
Comment 4 Brion Vibber 2012-02-23 01:34:24 UTC
Per in-person chat w/ Robla & Roan there's a few more things I can check out (modules vs CSS load order, DOM manipulation order, or changing how the positioning gets done)...

I'm keeping the bug open pending further investigation.
Comment 5 Brion Vibber 2012-02-23 19:29:45 UTC
r112229 loads the styles early; there is stuff in the original HTML though it's hidden until add'l styles are applied to it.

Everything *should* be fine since it's all hidden until we adjust it, and the styles and JS seem to be in the same package, so not sure why this even happens...
Comment 6 Brion Vibber 2012-02-23 20:10:09 UTC
Haven't been able to repro the click bug on Commons since r112229 went live, but I still sometimes see the flash of unstyled text briefly so it could still happen. Sigh.

Additionally, if you change the window size it's possible for the file input and button to get out of sync in their positioning, making part of the button unclickable -- this is due to the way the positioning is being done as a one-off adjustment.
Comment 7 Erik Moeller 2012-02-23 20:31:39 UTC
I'm still able to get it about 1/20, seems to be independent of the observable FOUC.
Comment 8 Brion Vibber 2012-02-23 22:05:27 UTC
r112248 uses an interval timer instead of the earlier one-off timeout to update every half second as necessary. This should help with initial layout cases, but also helps with the layout changing due to the window being resized later.
Comment 9 Erik Moeller 2012-02-23 23:16:57 UTC
Confirmed fixed, unable to repro the issue at this time (at worst it takes a tiny bit longer to respond to the click).

Note You need to log in before you can comment on or make changes to this bug.