Last modified: 2014-09-16 23:57:40 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T63886, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 61886 - Document in style guide how to use mw-ui-button on wiki using mw-ui-button span inside an anchor


Summary:	Document in style guide how to use mw-ui-button on wiki using mw-ui-button sp...

Status:	RESOLVED DUPLICATE of bug 48184

Product:	MediaWiki
Classification:	Unclassified
Component:	MediaWiki UI (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal normal (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:	https://www.mediawiki.org/wiki/MediaW...
Whiteboard:
Keywords:

Duplicates:	63275 (view as bug list)
Depends on:
Blocks:	documentation
	Show dependency tree / graph

Reported:	2014-02-25 01:55 UTC by spage
Modified:	2014-09-16 23:57 UTC (History)
CC List:	9 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description spage 2014-02-25 01:55:20 UTC

Pages and templates wrap hyperlinks with span tags to make buttons, see URL above and e.g. https://en.wikipedia.org/wiki/Template:Blue_button and https://commons.wikimedia.org/wiki/Template:Clickable_button

This doesn't work with mw-ui-button mw-ui-progressive. The hyperlink styling in skins/common/commonElements.css 
  a { color: #0645ad; }
and the browser's handling of visited/unvisited hy win out over the surrounding Agora styling.

Perhaps mediawiki.ui.button should apply styles to <a> tags within.  Or pages can put spans inside links, so instead of
  <span class="mw-ui-button mw-ui-progressive mw-ui-big">[[Download|Get MediaWiki]]</span>
use
  [[Download|<span class="mw-ui-button mw-ui-progressive mw-ui-big">Get MediaWiki</span>]]

If the latter works reliably then this bug can be WONTFIX.

In generated HTML we specifying classes directly on the link, i.e. <a href class="mw-ui-...">, but there are bugs with that too, e.g. bug 48184.

Comment 1 Bartosz Dziewoński 2014-02-25 02:00:45 UTC

(In reply to spage from comment #0)
> Perhaps mediawiki.ui.button should apply styles to <a> tags within.  Or
> pages can put spans inside links, so instead of
>   <span class="mw-ui-button mw-ui-progressive mw-ui-big">[[Download|Get
> MediaWiki]]</span>
> use
>   [[Download|<span class="mw-ui-button mw-ui-progressive mw-ui-big">Get
> MediaWiki</span>]]
> 
> If the latter works reliably then this bug can be WONTFIX.

The latter should always work, even on silly old browsers. We should, however, explicitly document (and support) that people should use a <span> here, never a <div>, otherwise Tidy will destroy the HTML (that's I think bug 9737 in particular and bug 2542 in general).

Comment 2 Bartosz Dziewoński 2014-02-25 02:02:18 UTC

(I agree with the WONTFIX proposal, trying to support the format syntax looks like a nasty hack to me.)

Comment 3 Matthew Flaschen 2014-02-25 22:55:49 UTC

I'm changing this to a doc bug.  We should add examples to http://tools.wmflabs.org/styleguide/desktop/section-2.html explicitly noting it's for on-wiki markup (i.e. the span method).

Comment 4 Matthew Flaschen 2014-03-31 22:14:22 UTC

*** Bug 63275 has been marked as a duplicate of this bug. ***

Comment 5 Jon 2014-08-28 18:56:32 UTC

So.. what is the bug here? Can some

Comment 6 Jon 2014-09-16 23:57:40 UTC

There's a lot of overlap with bug 48184 so let's collapse this into one bug for clarity.

*** This bug has been marked as a duplicate of bug 48184 ***

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links