Last modified: 2014-02-23 11:43:42 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T62997, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 60997 - Math at wmf/1.23wmf12 HEAD seems pretty broken
Math at wmf/1.23wmf12 HEAD seems pretty broken
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Math (Other open bugs)
unspecified
All All
: Highest major with 4 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
: tracking
: 61041 (view as bug list)
Depends on: 60988 60989 60990 60992 60996 61012 61026
Blocks: tracking 61808
  Show dependency treegraph
 
Reported: 2014-02-06 21:45 UTC by Sam Reed (reedy)
Modified: 2014-02-23 11:43 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Sam Reed (reedy) 2014-02-06 21:45:32 UTC
Moving the Wikipedias over to wmf/1.23wmf12 seems to be causing major cluster issues

Numerous bugs have been filed for some very weird looking errors on the cluster...
Comment 1 Sam Reed (reedy) 2014-02-06 21:47:33 UTC
Likely cause: https://gerrit.wikimedia.org/r/#/c/104991/
Comment 2 Andre Klapper 2014-02-07 18:24:16 UTC
*** Bug 61041 has been marked as a duplicate of this bug. ***
Comment 3 physikerwelt 2014-02-08 22:44:24 UTC
The patch Sam Reed points to (https://gerrit.wikimedia.org/r/#/c/104991/) seems to produce a high load. Aaron analyzed that via https://graphite.wikimedia.org/render/?width=849&height=455&_salt=1391893417.452&target=MediaWiki.MathHooks.mathTagHook.tavg&from=-7days
This load is caused by design. See https://bugzilla.wikimedia.org/show_bug.cgi?id=49169
If the high load is problematic, we need to disable the feature (like $wgMathCheckFiles=false before) again via ($wgMathDisableTexFilter = true) or cache the results of the check. However, this would cause a database lookup. An alternative would be to check via PHP. For a checking via PHP code we would need a very good code review of https://github.com/physikerwelt/texvcCheckPhp. I guess that would require a few days of fulltime work (even for an experienced) PHP programmer.
In general I have the feeling that my goal to improve the math rendering in Wikipedia has more negative effects than positive effects for the users. I don't think the problem is that I did a bad job, but I have the impression that I did not manage to find a suitable code reviewer for the Math2.0 change. And breaking down the change to several small commits (that are merged by random choice) creates more problems than it solves. I think the only way to do a good job and create a smooth transition from Math 1.1 to Math 2.0 is to find an experienced MediaWiki-PHP developer and go through the changes in one or two days in a personal meeting. I’m still in Berlin next week and I’ll move to Tokyo until April. So in general there should be good chances to meet someone in person.
Comment 4 Peter Krautzberger 2014-02-10 11:44:13 UTC
Hi,

I just wanted to write in support of physikerwelt's comment above. 

It seems very unfortunate that his commits are still not completely reviewed since they will provide major improvements to math rendering on Wikipedia.

I understand if the problem is that it is not just an incremental change but a rather large overhaul of some rather outdated architecture. But it seems that should make it more urgent rather than less.

Unfortunately, physikerwelt's attempt to break up the commit backfired a bit. Perhaps this can motivate one of the experts at WMF to work with physikerwelt to review the entire set of commits. 

Of course, we (at MathJax) are happy to help with fixing MathJax issues, both client-side and on mathoid.

Peter.
Comment 5 Gerrit Notification Bot 2014-02-14 23:42:19 UTC
Change 113480 had a related patch set uploaded by Aaron Schulz:
Update the DB output hash if outdated according to texvc

https://gerrit.wikimedia.org/r/113480
Comment 6 Gerrit Notification Bot 2014-02-14 23:52:37 UTC
Change 113480 merged by jenkins-bot:
Update the DB output hash if outdated according to texvc

https://gerrit.wikimedia.org/r/113480
Comment 7 Gerrit Notification Bot 2014-02-14 23:56:35 UTC
Change 113481 had a related patch set uploaded by Aaron Schulz:
Update the DB output hash if outdated according to texvc

https://gerrit.wikimedia.org/r/113481
Comment 8 Gerrit Notification Bot 2014-02-14 23:57:11 UTC
Change 113481 merged by jenkins-bot:
Update the DB output hash if outdated according to texvc

https://gerrit.wikimedia.org/r/113481

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links