Last modified: 2014-07-17 19:15:35 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T60663, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 58663 - media viewer doesn't preserve thumbnail options like svg language
media viewer doesn't preserve thumbnail options like svg language
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
MultimediaViewer (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
: 68154 (view as bug list)
Depends on:
Blocks: 16052
  Show dependency treegraph
 
Reported: 2013-12-18 19:39 UTC by Bawolff (Brian Wolff)
Modified: 2014-07-17 19:15 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Bawolff (Brian Wolff) 2013-12-18 19:39:21 UTC
Steps to reproduce:
*Go to https://test.wikipedia.org/wiki/File:SystemLanguage_test.svg
*Click on one of the images in the "Other version" section of the description (not the english one)
*Expected behaviour: MediaViewer shows the image in the correct language
*Actual behaviour: MediaViewer shows image in english

At the moment there's only a very small number of such images ([[commons:Category:Translation_possible_-_SVG_(switch)]]), so probably not a big deal initially, but its possible such images will take off in the future. Other formats might have other parameters that are important (PDF/DjVu page comes to mind), it would be nice if we could somehow support extra parameters just in general.
Comment 1 Mark Holmquist 2013-12-27 22:27:09 UTC
Blocker: There is no API module for this. See https://gerrit.wikimedia.org/r/25838 - either Harry forgot to add it or it was deemed not useful. There is no way to get a language-specific thumb URL as far as I can see.
Comment 2 Mark Holmquist 2013-12-27 22:27:35 UTC
PDF pages are supported via iiurlparam, as a hint - image language could be supported the same way.
Comment 3 Bawolff (Brian Wolff) 2013-12-28 01:02:29 UTC
(In reply to comment #2)
> PDF pages are supported via iiurlparam, as a hint - image language could be
> supported the same way.

It should already be. The implementation of that is generic for all media handlers
Comment 4 Mark Holmquist 2013-12-28 02:19:43 UTC
http://commons.wikimedia.org/w/api.php?action=query&titles=File:Gerrit%20patchset%2025838%20test.svg&prop=imageinfo&iiprop=url&iiurlwidth=300&iiurlparam=langde-300px

That's super annoying to discover. i.e. impossible to discover. Documentation fail. Bug 1 etc. etc.

It should be possible to look for extra params and just pass them to the iiurlparam parameter. I think. Probably. I'm not totally convinced that the thumb URL will always be exactly the same, but in most cases it will, so let's go with it!
Comment 5 Bawolff (Brian Wolff) 2013-12-28 05:57:55 UTC
(In reply to comment #4)
> http://commons.wikimedia.org/w/api.php?action=query&titles=File:
> Gerrit%20patchset%2025838%20test.
> svg&prop=imageinfo&iiprop=url&iiurlwidth=300&iiurlparam=langde-300px
> 
> That's super annoying to discover. i.e. impossible to discover. Documentation
> fail. Bug 1 etc. etc.

Indeed it really is. It was originally a hack to make instant commons work. It is totally and utterly undiscoverable.

> It should be possible to look for extra params and just pass them to the
> iiurlparam parameter. I think. Probably. I'm not totally convinced that the
> thumb URL will always be exactly the same, but in most cases it will, so
> let's
> go with it!

It should always be the same.
Comment 7 C. Scott Ananian 2014-05-29 19:53:13 UTC
See also bug 58920, which quibbles with the desired semantics of 'systemLanguage'.
Comment 8 Tisza Gergő 2014-07-17 19:13:14 UTC
*** Bug 68154 has been marked as a duplicate of this bug. ***
Comment 9 Tisza Gergő 2014-07-17 19:15:35 UTC
I think this actually works now (with thumbnail guessing, although not with thumbnails requested via the API), and the mixing of the languages is due to bug 62039.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links