Last modified: 2014-06-24 18:17:20 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T59732, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 57732 - Sitenotice can't be dismissed by unregistered users
Sitenotice can't be dismissed by unregistered users
Status: PATCH_TO_REVIEW
Product: MediaWiki extensions
Classification: Unclassified
DismissableSiteNotice (Other open bugs)
unspecified
All All
: High major (vote)
: ---
Assigned To: Dror S.
:
: 26875 (view as bug list)
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-11-29 09:15 UTC by Nemo
Modified: 2014-06-24 18:17 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Nemo 2013-11-29 09:15:45 UTC 
Per Brion's bug 9209 comment 4, making the sitenotice dismissable (and loaded via JavaScript) for unregistered users is one of the main requirements of this extension.

I don't know exactly at what point this stopped working, I noticed only now. It was reported in 2012 at [[mw:Extension_talk:DismissableSiteNotice#How_can_anons_dismiss_a_notice.3F]].
Comment 1 Dror S. 2013-12-26 14:47:13 UTC 
I'm doing this right now, thanks to the TLV hackathon - by reintroducing $wgDismissableSiteNoticeForAnons.
I don't like it, but I'm going to keep the current encodeJsCall behavior for anons, in order not to introduce any Google-snippet-related issues.
Comment 2 Dror S. 2013-12-26 14:50:58 UTC 
*** Bug 26875 has been marked as a duplicate of this bug. ***
Comment 3 Dror S. 2014-02-12 21:28:22 UTC 
Submitted Gerrit change #112951.
Comment 4 Gerrit Notification Bot 2014-02-12 21:46:36 UTC 
Change 112951 had a related patch set uploaded by Nemo bis:
Allow anonymous users to dismiss the sitenotice

https://gerrit.wikimedia.org/r/112951
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links