Last modified: 2013-04-02 01:48:37 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T11209, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 9209 - DismissableSiteNotice relies on JavaScript to render site notice
DismissableSiteNotice relies on JavaScript to render site notice
Product: MediaWiki extensions
Classification: Unclassified
DismissableSiteNotice (Other open bugs)
All All
: Lowest normal (vote)
: ---
Assigned To: Rob Church
: accessibility
Depends on:
  Show dependency treegraph
Reported: 2007-03-07 12:47 UTC by jisok2
Modified: 2013-04-02 01:48 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Description jisok2 2007-03-07 12:47:20 UTC
The site notice is shown at the top of each page. This feature requires javascript.
(I asked admins to change it, and replied that they have no power to do that.
Comment 1 Rob Church 2007-03-07 12:49:28 UTC
You're referring to the "dismiss" feature, I assume? The site notice itself
should require no JavaScript to be *shown*.
Comment 2 jisok2 2007-03-07 12:55:36 UTC
No, the notice itself is not displayed in non-script browsers. You can easily
see it in any ko.wikipedia page.
Comment 3 Rob Church 2007-03-07 13:37:15 UTC
Ah, I see. Looking into it.
Comment 4 Brion Vibber 2007-03-07 23:18:22 UTC
The sitenotice is shown via JavaScript when dismissable sitenotice extension is
in use.
This is a deliberate choice, to avoid polluting search engines with the site notice.
Comment 5 Aryeh Gregor (not reading bugmail, please e-mail directly) 2007-03-08 02:33:16 UTC
That seems . . . hacky?  Why is it so important to stop searchbots from seeing it?  I guess it would 
become outdated, but so could any number of things on the page.  It seems better to let them see 
it.  It would typically be irrelevant to search results anyway, and so not really influence them.
Comment 6 Brion Vibber 2007-03-08 19:02:22 UTC
If you think adding a link to millions of pages on one of the top
sites on the web will be "irrelevant to search results", well... :)

It is a bit ugly, but it beats the alternatives for now until we completely
change how sitenotices are done.
Comment 7 Dan Jacobson 2009-08-14 19:41:56 UTC
[Before reading the above I had already prepared:]
I hereby "file suit" against the DismissableSiteNotice extension, for
violating accessibility.

On vanilla MediaWiki sites, all users always see MediaWiki:Sitenotice,
but with your extension installed, non-javascript users will never see

That is because you have forgotten to add any <noscript> statements.
[After reading the above... I think you are all... OK, fine, e.g., wikia wiki sysops have no way of making a MediaWiki:Sitenotice that all users can see for certain.]
Comment 8 Kevin Israel (PleaseStand) 2013-04-02 01:48:37 UTC
Brion, you may wish to weigh in on whether the document.writeln() hack is still necessary.

I have a pending change Gerrit change #56780 that eliminates the hack for logged-in users, and it would be good to get rid of it for anons as well.

Note You need to log in before you can comment on or make changes to this bug.