Last modified: 2014-04-03 08:13:36 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T58259, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 56259 - jQuery.valueview.Expert.prototype.draw() should not be responsible for non-edit mode >> getting rid of BifidExpert
jQuery.valueview.Expert.prototype.draw() should not be responsible for non-ed...
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Wikidata bugs
u=dev c=frontend p=13
: javascript
Depends on: 56263
Blocks: 54098 55693 60341 61739
  Show dependency tree / graph
 
Reported: 2013-10-28 17:39 UTC by Daniel A. R. Werner
Modified: 2014-04-03 08:13 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Daniel A. R. Werner 2013-10-28 17:39:54 UTC 
Redefine jQuery.valueview.Expert's draw functions to not be responsible for non-edit mode representation of data values.

For this purpose we should have value formatters in the frontend. Instead of having experts acting as formatters, a formatter factory should be injected into jQuery.valueview widgets just like an ExpertFactory instance is injected there.

This will allow to get rid of the jQuery.valueview.BifidExpert and increase testability of the experts in general as well as reduce their complexity.
Comment 1 Daniel A. R. Werner 2013-11-06 03:06:26 UTC 
I don't agree with this bug's current severity/priority rating at all. This is the kind of continuous refactoring that is required to not end up with a huge mess after the next two features got implemented into the component.

Currently we already have a huge mess in the Time/Geo experts, this could be a first step into improving the situation.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links