Last modified: 2014-10-09 14:23:02 UTC
Steps to reproduce: *Start upload wizard *Upload 2 files *Give them the same name on the describe step *hit done Expected behaviour: *Upload wizard should give an error to the user, as this is almost certainly not what the user meant to do. Presumably this was a typo on the part of the user, and they did not mean for the files to have same title (or didn't realize there is 1:1 relation of titles to files. In any case, if user is uploading 2 files at the same time, they probably want them to be separate files. Actual behaviour: *Upload wizard uploads the first file, and then uploads the second file over top of the first. Additional actual behaviour: *Race conditions galore in the backend cause bad things to happen, and data-loss on one of the files. See bug 54736. However, even if that didn't happen, this is still a behaviour of upload wizard that I think should be fixed.
*** Bug 34230 has been marked as a duplicate of this bug. ***
Thanks for mentioning this in bug 54776, I had seen the summary in my search results but I thought it was another thing (the bug I just duplicated to this).
*** Bug 56678 has been marked as a duplicate of this bug. ***
*** Bug 31208 has been marked as a duplicate of this bug. ***
Would it be possible to check a Commons dump to see how often this occurs? It should be detectable as a upload over an existing file with the edit comment "User created page with UploadWizard" [1]. Since the wizard does not allow re-uploading this should only ever occur in this case. [1] https://commons.wikimedia.org/w/index.php?title=Special:Log&page=File%3AInstrument+-+Karin+Ohlin%2C+2.jpg
Note, potential dupe at bug 64883 (But this one was here first). (In reply to Lokal_Profil from comment #5) > Would it be possible to check a Commons dump to see how often this occurs? > It should be detectable as a upload over an existing file with the edit > comment "User created page with UploadWizard" [1]. Since the wizard does not > allow re-uploading this should only ever occur in this case. > > [1] > https://commons.wikimedia.org/w/index.php?title=Special: > Log&page=File%3AInstrument+-+Karin+Ohlin%2C+2.jpg MariaDB [commonswiki_p]> select count(*) from logging_logindex where log_type = 'upload' and log_action = 'overwrite' and log_comment = 'User created page with UploadWizard' ; +----------+ | count(*) | +----------+ | 19511 | +----------+ 1 row in set (2 min 55.42 sec)
*** Bug 64883 has been marked as a duplicate of this bug. ***
Change 133434 had a related patch set uploaded by Rillke: UploadWizard: Check for duplicate titles https://gerrit.wikimedia.org/r/133434
Change 133434 merged by jenkins-bot: UploadWizard: Check for duplicate titles https://gerrit.wikimedia.org/r/133434
Couldn't trivially backport.
