Last modified: 2013-10-17 18:06:01 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T55427, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 53427 - New field and index on recentchanges table for RC_EXTERNAL
New field and index on recentchanges table for RC_EXTERNAL
Status: RESOLVED INVALID
Product: Wikimedia
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: High normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: schema-change
Depends on:
Blocks: 49188
  Show dependency treegraph
 
Reported: 2013-08-27 21:36 UTC by Erik Bernhardson
Modified: 2013-10-17 18:06 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Erik Bernhardson 2013-08-27 21:36:00 UTC
Short description:

Add a new field and index to allow differentiation between types of RC_EXTERNAL changes.  Currently Wikibase is the only thing using RC_EXTERNAL. To allow Flow to utilize RC_EXTERNAL and let Wikibase continue doing everything it does now a differentiator is required.

Which wikis are affected:

all?

Which tables:

recentchanges

What is the change to those tables:

ALTER TABLE recentchanges ADD rc_external_type VARBINARY(255) NULL DEFAULT NULL;
CREATE INDEX rc_type ON recentchanges(rc_type, rc_external_type);

Links to gerrit changes and/or other related bug reports.

https://bugzilla.wikimedia.org/53230
https://gerrit.wikimedia.org/r/#/c/81277
Comment 1 Erik Bernhardson 2013-09-09 22:40:47 UTC
After further review we have decided the index is unnecessary and the size of this field should be 16 rather than 255.

The change required is now just: 

ALTER TABLE recentchanges ADD rc_external_type VARBINARY(16) NULL DEFAULT
NULL;
Comment 2 Sam Reed (reedy) 2013-10-17 00:37:20 UTC
Where's the accompanying changeset for this as 81277 has been abandoned? Or should this bug be closed as INVALID or similar?
Comment 3 Erik Bernhardson 2013-10-17 18:06:01 UTC
As mentioned by reedy, after consultation with wikitech and other interested
parties the solution to this problem changed and there is no longer a need to
add rc_external_type to the recentchanges table.

The solution taken involves replacing rc_type int field in recentchanges with a new rc_source varbinary(16) field.

This has been superseeded by bug 55844

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links