Last modified: 2014-02-10 04:35:41 UTC
tables: archive, externallinks, external_user (new)
changes: New fields: ar_id, el_id.
status: Needs review
links: Gerrit change #51675, bug 15441, bug 39675
Reedy: adding you on CC since you own the patch. Do you have a priority/importance for this schema change?
(In reply to comment #1)
> Reedy: adding you on CC since you own the patch. Do you have a
> priority/importance for this schema change?
Not really. Long overdue more than anything.
Merging that patch wouldn't make any difference to core as it's not currently used. But likelihood that it would start being used properly, even more when there'
(In reply to comment #2)
> Merging that patch wouldn't make any difference to core as it's not currently
> used. But likelihood that it would start being used properly, even more when
There's a script to back populate the ar_len field. To populate this easily/efficiently, this PK is really needed
*** Bug 49198 has been marked as a duplicate of this bug. ***
As a reminder, replicated a redacted version of archive to labs is pending on the addition of the primary key on archive.
ar_id has been added to all wikis except enwiki where it's still in progress. Another day or so required there as I have it well dialed back to avoid lagging slaves.
el_id change will begin afterwards.
It's slow going because the online alteration method I'm using is two-stage to compensate for the lack of primary and unique keys.
In hindsight altering these two tables online hasn't really saved much wall-clock time compared to altering tables on slaves and rotating masters, but it has nicely avoided any client disruption.
@Sean: Any update on this?
el_id still remains to be added to several of the larger wikis, including enwiki. Other issues have put this process on (hopefully brief) hold.
Increase priority, because a change to master was merged, where the new field el_id is needed. To avoid fatal on wmf branch a fix is needed, see Gerrit change #105243, or the revert Gerrit change #107415 or bug 58435.
Anyone got a time machine?
Sean, where are we up to now? I know domas killed one alter..
Yes, one schema change job broke replication so the others were put on hold. The remaining wikis are:
I'll need to do master rotations for these.
Higher priority noted.
This is now complete. All wikis have both ar_id and el_id.