Last modified: 2014-02-10 02:02:26 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T50133, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 48133 - [InstantCommons] Some hotlinks of Commons files are not protocol-relative
[InstantCommons] Some hotlinks of Commons files are not protocol-relative
Status: NEW
Product: MediaWiki
Classification: Unclassified
File management (Other open bugs)
1.22.0
All All
: Normal major (vote)
: ---
Assigned To: Nobody - You can work on this!
https://translatewiki.net/wiki/Thread...
:
: 47653 (view as bug list)
Depends on:
Blocks: ssl 39480
  Show dependency treegraph
 
Reported: 2013-05-06 09:55 UTC by Nemo
Modified: 2014-02-10 02:02 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Nemo 2013-05-06 09:55:05 UTC
1) Visit https://translatewiki.net/wiki/Project:About (HTTPS)
2) Purge it
3) Check http://translatewiki.net/wiki/Project:About source

Observed: some hotlinks of Commons files are over HTTPS. (It used to be the opposite, but it seems I can't reproduce by purging on HTTP...)

Expected: $wgUseInstantCommons includes protocol-relative resources and doesn't add insecure content to secure pages.

On closer inspection this is even weirder, because some resources are protocol-relative and some are not:

<img alt="Torchlight kopete.png" src="https://upload.wikimedia.org/wikipedia/commons/5/57/Torchlight_kopete.png" width="135" height="135" />

but

<img alt="P economy blue.png" src="/w/images/thumb/1/1a/P_economy_blue.png/135px-P_economy_blue.png" width="135" height="124" srcset="https://upload.wikimedia.org/wikipedia/commons/1/1a/P_economy_blue.png 1.5x, https://upload.wikimedia.org/wikipedia/commons/1/1a/P_economy_blue.png 2x" />

(I've no idea what "srcset" is).
Comment 1 Alex Monk 2013-05-06 14:51:14 UTC
(In reply to comment #0)
> (I've no idea what "srcset" is).

It's this: Gerrit change #24115
Comment 2 Nemo 2013-05-06 15:01:11 UTC
(In reply to comment #1)
> (In reply to comment #0)
> > (I've no idea what "srcset" is).
> 
> It's this: Gerrit change #24115

So is it a coincidence that, when that fails and no srcset is added, MediaWiki also fails to use the correct (protocol-relative) src?
Comment 3 Nemo 2013-05-25 10:56:30 UTC
*** Bug 47653 has been marked as a duplicate of this bug. ***
Comment 4 Bawolff (Brian Wolff) 2013-10-02 00:26:14 UTC
At first glance, maybe the difference is if it was a thumbnailed file vs if original file.
Comment 5 Siebrand Mazeland 2013-12-19 22:25:35 UTC
I cannot reproduce the observations after step 3 any more.
Comment 6 Nemo 2013-12-20 10:27:19 UTC
(In reply to comment #5)
> I cannot reproduce the observations after step 3 any more.

I can still reproduce that some are protocol-relative and some are not.
Comment 7 Alex Monk 2014-02-10 02:02:26 UTC
(In reply to comment #0)
> <img alt="P economy blue.png"
> src="/w/images/thumb/1/1a/P_economy_blue.png/135px-P_economy_blue.png"
> width="135" height="124"
> srcset="https://upload.wikimedia.org/wikipedia/commons/1/1a/P_economy_blue.
> png
> 1.5x, https://upload.wikimedia.org/wikipedia/commons/1/1a/P_economy_blue.png
> 2x" />

I don't know why we're discussing what protocols are being used - why is the src of this a local resource but the srcset pointing to commons?

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links