Last modified: 2014-04-05 18:44:31 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T49653, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 47653 - wikimedia.de via HTTPS loads resources over HTTP
wikimedia.de via HTTPS loads resources over HTTP
Status: RESOLVED DUPLICATE of bug 48133
Product: MediaWiki
Classification: Unclassified
File management (Other open bugs)
1.20.x
All All
: Normal normal (vote)
: 1.21.0 release
Assigned To: Nobody - You can work on this!
: upstream
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-04-25 16:15 UTC by MZMcBride
Modified: 2014-04-05 18:44 UTC (History)
11 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description MZMcBride 2013-04-25 16:15:26 UTC
When I visit <https://wikimedia.de/wiki/Hauptseite>, there are a few resources coming in via HTTP, causing my Web browser to throw warnings.

<img alt="" src="http://upload.wikimedia.org/wikipedia/commons/thumb/6/66/Wikidata-logo-en.svg/170px-Wikidata-logo-en.svg.png" width="170" height="120" />

<img alt="Wikipedianer auf Exkursion im Kirchenarchiv Kaufbeuren. Foto: Benutzerin:Elya, CC-BY-SA 3.0" src="http://upload.wikimedia.org/wikipedia/commons/thumb/0/09/GLAM-Aktivisten_im_Kirchenarchiv_Kaufbeuren_04.JPG/170px-GLAM-Aktivisten_im_Kirchenarchiv_Kaufbeuren_04.JPG" width="170" height="128" />

<img alt="Logo von Wikivoyage" src="http://upload.wikimedia.org/wikipedia/commons/thumb/1/1b/Wikivoyage-logo-en-TTO-attempt.svg/170px-Wikivoyage-logo-en-TTO-attempt.svg.png" width="170" height="180" />

[a bunch of other images ...]

<img src="http://i.creativecommons.org/l/by-sa/3.0/88x31.png" alt="Attribution-Share Alike 3.0 Unported" width="88" height="31" />

<img src="http://secure.wikimedia.de/piwik/piwik.php?idsite=2" style="border:0" alt=""/>

This is probably the not the best place to report this issue, but I couldn't find a better place and I figured some of the German Wikimedians can be copied on this bug report and can forward this issue as necessary and appropriate.
Comment 1 Sam Reed (reedy) 2013-04-26 01:12:12 UTC
This isn't the right place for this. WMF doesn't host the wikimedia.de wiki.

I note Daniel is CC'd on this bug
Comment 2 Daniel Kinzler 2013-04-26 09:40:27 UTC
I have passed on responsibility for this a while ago, but i'll try to poke the relevant people, and help them fix it (I'm pretty sure this was my mistake).

Adding Silke Meyer (who is technically responsible) and Kai Nissen (who has been managing the site).

@Sam: WMDE doesn't have a bug tracker for stuff like this, perhaps we could just get a product here? 

I'll re-open the bug with the new assignee; if you feel it's really in the way here, close it again. We'll figure out another solution, then.
Comment 3 Andre Klapper 2013-04-26 11:30:09 UTC
p858snake: What is "upstream" here???

(In reply to comment #2)
> @Sam: WMDE doesn't have a bug tracker for stuff like this, perhaps we could
> just get a product here? 

Please file a separate ticket to discuss this.
Comment 4 Kai Nissen 2013-04-26 20:31:04 UTC
The protocol type that has been used to get the file info from commons.wikimedia.org gets cached by the parser cache. This will happen vice versa, if the parser caches when requesting with https.

I customized the ForeignAPIRepo for commons to always use the secure protocol when requesting the commons API, but changing ForeignAPIRepo::getThumbUrl() to strip the protocol and make the src attribute protocol-relative seems to be the solution here.

I will provide a patch this weekend.

@MZMcBride: The other images that are not provided by commons were also changed to protocol-relative.
Comment 5 Gerrit Notification Bot 2013-04-29 15:58:20 UTC
Related URL: https://gerrit.wikimedia.org/r/61390 (Gerrit Change Id40186d10019a77f8b827a6a67982d40f3e97f11)
Comment 6 Andre Klapper 2013-05-13 13:38:22 UTC
Patch needs rework.
Comment 7 Nemo 2013-05-25 10:56:30 UTC
(In reply to comment #6)
> Patch needs rework.

More than that, Anomie said "Your analysis of the problem in the commit summary is not correct". This bug is indeed misleading and is a duplicate of something the reporter already reported previously and that I had already clarified as bug 48133.

*** This bug has been marked as a duplicate of bug 48133 ***
Comment 8 Gerrit Notification Bot 2014-04-05 18:44:31 UTC
Change 61390 abandoned by Siebrand:
(bug 47653) Processing foreign API files protocol-relative

Reason:
I'm abandoning this patch set as it's been open for a long time without any outlook at the open issues being resolved. 

If the submitter or anyone else would like to work on it again, this patch set can be re-activated by clicking "Restore Change". Please only do this if you are actually going to work on it immediately.

https://gerrit.wikimedia.org/r/61390

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links