Last modified: 2013-03-13 16:25:09 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T47127, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 45127 - Wikidata specific copyright notice


Summary:	Wikidata specific copyright notice

Status:	VERIFIED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	WikidataRepo (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Highest normal (vote)
Target Milestone:	---
Assigned To:	Wikidata bugs

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	44515
	Show dependency tree / graph

Reported:	2013-02-18 17:59 UTC by denny vrandecic
Modified:	2013-03-13 16:25 UTC (History)
CC List:	5 users (show)

See Also:	45645
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description denny vrandecic 2013-02-18 17:59:06 UTC

The pop up message contains a Wikidata-specific copyright-notice which comes from the WikimediaMessages extension (key 'wikidata-shortcopyrightwarning').

This is hardcoded in the mw1.21-wmf10 branch in repo/incluedes/EntityView.php , which is absolutely horrible and I apologize for this.

Before the wmf11 deployment, this needs to be fixed in EntityView by calling a hook which is implemented in WikimediaMessages and which replaces the message from Wikibase as it is with the wikidata-shortcopyrightwarning message.

The hotfix for wmf10 is in here: https://gerrit.wikimedia.org/r/#/c/49694/

I surely hope it will not be backported to wmf11.

Comment 1 tobias.gritschacher 2013-03-07 14:11:15 UTC

This was done for wmf11:
https://gerrit.wikimedia.org/r/#/c/52406/

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links