Last modified: 2013-10-24 16:12:16 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T46718, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 44718 - AbortNewAccount hook was changed accidentially in I402c6beb


Summary:	AbortNewAccount hook was changed accidentially in I402c6beb

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	User login and signup (Other open bugs)
Version:	1.21.x
Hardware:	All All

Importance:	High normal (vote)
Target Milestone:	---
Assigned To:	Tyler Romeo

URL:	https://gerrit.wikimedia.org/r/17952
Whiteboard:
Keywords:	easy

Duplicates:	38894 (view as bug list)
Depends on:
Blocks:	52191
	Show dependency tree / graph

Reported:	2013-02-06 16:26 UTC by Liangent
Modified:	2013-10-24 16:12 UTC (History)
CC List:	9 users (show)

See Also:	52191 38894
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Liangent 2013-02-06 16:26:03 UTC

In the past, hooks can set an HTML error message via the second argument $abortError. After I402c6beb, the message is treated as wikitext and parsed (again), causing HTML tags which are unacceptable in wikitext shown on pages, where old extensions like TitleBlacklist parse error messages themselves and send HTML output as $abortError.

Comment 1 Tyler Romeo 2013-02-06 21:27:46 UTC

Sorry about that. That's my fault. The reason is that even though the HTML is being wrapped in a RawMessage, I forgot that it was being parsed when it got returned to the parent function. I'll have a quick patch fix shortly.

Comment 2 Tyler Romeo 2013-02-07 00:44:58 UTC

This is a temporary fix. I will make a more robust fix when I construct a better way for messages to be stored within messages and for statuses to handle message parameters.

https://gerrit.wikimedia.org/r/47821

Comment 3 Andre Klapper 2013-05-16 16:07:29 UTC

(In reply to comment #2 by Tyler Romeo)
> This is a temporary fix.
> https://gerrit.wikimedia.org/r/47821

Patch in Gerrit still awaiting review & merge. :-/

Comment 4 Gerrit Notification Bot 2013-06-30 20:47:17 UTC

Change 47821 had a related patch set uploaded by Matmarex:
Fix double-parsing of account creation messages.

https://gerrit.wikimedia.org/r/47821

Comment 5 Tyler Romeo 2013-08-02 18:45:57 UTC

*** Bug 38894 has been marked as a duplicate of this bug. ***

Comment 6 Liangent 2013-09-20 12:28:38 UTC

*** Bug 54336 has been marked as a duplicate of this bug. ***

Comment 7 Gerrit Notification Bot 2013-10-24 10:35:33 UTC

Change 47821 merged by jenkins-bot:
Fix double-parsing of account creation messages.

https://gerrit.wikimedia.org/r/47821

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links