Last modified: 2013-04-19 23:32:22 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T46442, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 44442 - VisualEditor: Oddness repetition/wrong diff (from Parsoid?) on save with some funky markup
VisualEditor: Oddness repetition/wrong diff (from Parsoid?) on save with some...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2013-04-29
Assigned To: James Forrester
https://en.wikipedia.org/w/index.php?...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-01-28 22:32 UTC by Chris McMahon
Modified: 2013-04-19 23:32 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
empty review pane, should show heading markup for non-Latin string (28.74 KB, image/png)
2013-01-28 22:32 UTC, Chris McMahon
Details

Description Chris McMahon 2013-01-28 22:32:19 UTC
Created attachment 11701 [details]
empty review pane, should show heading markup for non-Latin string

Using a string like "āæǣ" or special characters like "☺☻♥♦"

Highlight the string in VE
Choose "Heading 1"

VE displays the string larger, as expected

Click "Review and save""

Note that review pane is empty, see screen shot. 
Click "Looks good to me" and finish saving. 

The non-Latin string has not been affected and the Heading not been applied. 

Note that normal ASCII latin strings work fine. 
Also note that the regular editor applies the Heading markup to non-latin strings correctly.
Comment 1 James Forrester 2013-01-28 23:27:11 UTC
Afraid I can't reproduce this (it works fine for me with Firefox, Safari and Chrome from here - I get as-expected diffs, which also then save appropriately) - what wiki / version of the software was this on, and with what browser?
Comment 2 Chris McMahon 2013-01-28 23:54:45 UTC
Chrome, OSX, enwiki. I can reproduce this reliably on my User page on enwiki.
Comment 3 Chris McMahon 2013-01-29 00:00:12 UTC
Also repro'd on Chrome/Linux
Comment 4 James Forrester 2013-01-29 01:22:45 UTC
OK, interesting. This is actually a quite complicated bug, and is not actually correctly-named.

The problem appears to be the '[http://barbarbar bar]' beforehand - if you remove this, the diff magically "works" - BUT it fails to show the '[http://barbarbar bar]' being removed, and indeed puts it after the header too, with another paragraph of 'āæǣ'. The diff is the behaviour that results from the save, even though this isn't a fair representation of the document model (the '[http://barbarbar bar]' is removed from the DM).

RK: this feels like a Parsoid bug (or two?), but might be on our side related to SelSer? - can you confirm before we sling it at them?
Comment 5 Chris McMahon 2013-01-29 01:44:52 UTC
This would make a nice automated browser regression test
Comment 6 燃玉 2013-01-29 12:47:54 UTC
I found it is impossible to use Sogou Input or other Input software to type Chinese with this tool.

You may download a Sogou Input(which is the most popular one in china, on the Windows) to test it.

Here is the download link: http://download.ime.sogou.com/sogou_pinyin_65f.exe?st=lTJ11fWyCsrUkj6oWiGI_Q&e=1359462829&fn=sogou_pinyin_65f.exe
Comment 7 James Forrester 2013-04-19 23:32:22 UTC
The underlying issue (with Parsoid) has been resolved with the new version of Parsoid finally running on the cluster; marking as FIXED.

[I have forked comment 6 into bug 47436.]

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links