Last modified: 2013-12-26 13:34:02 UTC
Created attachment 11516 [details] diff Reapply Bugmail.pm hack after Bugzilla upgrade from 4.0 to 4.2 as per discussion in http://lists.wikimedia.org/pipermail/wikitech-l/2012-December/064914.html . See attachment. After this has been done, the corresponding file in https://gerrit.wikimedia.org/r/gitweb?p=wikimedia%2Fbugzilla%2Fmodifications.git;a=summary needs to be updated too to keep Gerrit and code on the server in sync.
https://rt.wikimedia.org/Ticket/Display.html?id=4121
*** Bug 28402 has been marked as a duplicate of this bug. ***
https://gerrit.wikimedia.org/r/#/c/39528/
Daniel merged into 4.2 what is actually on kaulen here: > https://gerrit.wikimedia.org/r/#/c/39613/1/bugzilla-4.2/Bugzilla/BugMail.pm > but the file in 4.0 is untouched. so you can now diff both files from > the repo, and then apply a new patch to the 4.2 file Seeing how huge the diff was for https://gerrit.wikimedia.org/r/#/c/39613/1 and not feeling comfortable to spend a lot of time trying to understand what all that code is doing, I will happily leave this task to anybody who thinks that it's important to get that "no CC mail sent to wikibugs-l@" hack applied again. Personally I won't push for it.
Raising priority, because this is responsible of some 15 % of the bot traffic on #mediawiki, which people whine a lot about: see bug 28402 comment 8 for details.
I'd rather say: Fix the bot instead of patching Bugzilla. :)
I did a mistake in the bug summary: I proposed a potential solution instead of describing the problem, and https://www.mediawiki.org/wiki/How_to_report_a_bug says: "Summary: A short one-sentence summary that explains the problem (not your suggested solution)." Changing summary to "Make wikibugs-l not receive CC only changes" as this seems to be the one thing after reading http://lists.wikimedia.org/pipermail/wikitech-l/2012-December/064911.html .
Created attachment 12005 [details] wikibugs-l@ bugmail preferences I assumed that I could switch off the CC field notifications, but they ARE already switched off.
Sorry, last comment was made by me. Had forgotten to log out.
So the only way to fix this looks like somebody who speaks Perl will have to diff the file in Bugzilla 4.0 with the one in 4.2 (see comment 4 here): https://gerrit.wikimedia.org/r/gitweb?p=wikimedia/bugzilla/modifications.git;a=blob;f=bugzilla-4.0/Bugzilla/BugMail.pm;hb=HEAD https://gerrit.wikimedia.org/r/gitweb?p=wikimedia/bugzilla/modifications.git;a=blob;f=bugzilla-4.2/Bugzilla/BugMail.pm;hb=HEAD
So I don't really speak Perl, but it seems like the relevant part of the diff is what I submitted here: I0344d243. Please test and merge if it works as expected.
(In reply to comment #8) > Created attachment 12005 [details] > wikibugs-l@ bugmail preferences > > I assumed that I could switch off the CC field notifications, but they ARE > already switched off. I think its because wikibugs is global notifier. Note that wikibugs still get notices on things wikibugs is not assigned to or cc on so its not the normal email prefs feature
(In reply to comment #11 by MatmaRex) > So I don't really speak Perl, but it seems like the relevant part of the diff > is what I submitted here: I0344d243. Please test and merge if it works as > expected. Thanks (though I have no idea yet how to effectively *test* this)! (In reply to comment #12 by Bawolff) > I think its because wikibugs is global notifier. Yes, there is no indication for a Bugzilla user that none of the mail notification settings will have any affect, if an admin has set him/her as a globalwatcher. I realized this in bug 44929 and an upstream ticket exists.
(In reply to comment #13) > Thanks (though I have no idea yet how to effectively *test* this)! Honestly, I'd just merge&deploy it and confirm that nothing breaks. It's a simple reapplication of a hack that was live and worked for years, and the (one-line!) hack itself is beautifully straightforward - it makes BZ stop treating global watchers as global watchers and treats them as if they were CC'd on the bug instead. We *could* also meticulously set up another Bugzilla instance, make some accounts and global watchers on it, and them create some bugs and comment on them... but IMO there's no point; this hack will just work and the fix for this bug is long overdue.
(In reply to comment #14) > (In reply to comment #13) >> Thanks (though I have no idea yet how to effectively *test* this)! > > Honestly, I'd just merge&deploy it and confirm that nothing breaks. Agreed. From what I understand, though, Bugzilla, much like OTRS, is without a technical maintainer currently. Perhaps Daniel Z. would be willing to help?
(In reply to comment #15) > From what I understand, though, Bugzilla, much like OTRS, is without a > technical maintainer currently. Perhaps Daniel Z. would be willing to help? I maintain Bugzilla but would not call myself a coder. However the community and Daniel have been very helpful, so things get done (but not with stellar speed). OTRS is Philippe's "management" area and Martin Edenhofer (see bug 22622) is currently working on it, supported by WMF's Jeff Green.
(In reply to comment #16) > (In reply to comment #15) >> From what I understand, though, Bugzilla, much like OTRS, is without a >> technical maintainer currently. Perhaps Daniel Z. would be willing to help? > > I maintain Bugzilla but would not call myself a coder. Do you have the ability to modify Bugzilla's code? If not, then you're not the technical maintainer of Bugzilla. I'm talking about the ability to do software upgrades and make software tweaks.
(In reply to comment #14) > (In reply to comment #13) > Honestly, I'd just merge&deploy it and confirm that nothing breaks. I still get stomach ache as this destroys the traditional globalwatcher meaning for *all* globalwatchers to receive *all* bugmail (also CC only changes). Anyway... Asked for deployment in RT #4904.
https://gerrit.wikimedia.org/r/56879 (Gerrit Change I0344d24308d3b769410b78b1ab40badf6c0d5cc5) | change APPROVED and MERGED [by Demon]
The proposed change was merged live just now, and appears to be functioning as desired. Please test, and if it doesn't work, please re-open this ticket and let me know!
Thanks everybody (for help, patience and persistency)!
I heard someone speculating that wikibugs was posting CC-only changes again but I didn't find anything like that in the last couple days with the best URL I found to check i.e. <http://search.gmane.org/?query=%22What+|Removed+|Added+---+CC%22&author=&group=gmane.org.wikimedia.mediawiki.bugs&sort=date&DEFAULTOP=and&TOPDOC=20&xP=what%09removed%09added%09cc&xFILTERS=Gorg.wikimedia.mediawiki.bugs---A> Something else must have caused the peak at http://dir.gmane.org/gmane.org.wikimedia.mediawiki.bugs then. :)
