Last modified: 2013-02-14 07:46:39 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T45108, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 43108 - Login form is a table
Login form is a table
Status: RESOLVED DUPLICATE of bug 34751
Product: MediaWiki
Classification: Unclassified
User login and signup (Other open bugs)
1.21.x
All All
: High normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-12-14 01:55 UTC by Jon
Modified: 2013-02-14 07:46 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Jon 2012-12-14 01:55:30 UTC
Why is it contained in a table element?

This causes huge restrictions on how one can style it.
I am currently trying to style the login form to look like https://mingle.corp.wikimedia.org/attachments/3408386b028630169e1105579e7b53da/186/Wikipedia_Signup_-_iOS.png for mobile and it is impossible to do so without changes to the core.

Let's replace it with a form with clearly marked input elements and input labels. There is absolutely no need for the table elements.
Comment 1 Jon 2012-12-14 02:05:15 UTC
https://gerrit.wikimedia.org/r/38674 for more context.
Comment 2 Daniel Friesen 2012-12-14 02:26:40 UTC
Technically speaking given that the login form has keys and values (key = label, value = form input) a table is actually a rational markup.

That said, we actually do have some plans to change the form. Mixed in with various signup projects, form style guide, mobile stuff, etc...
Comment 3 Jon 2012-12-14 17:58:05 UTC
I don't understand your reasoning for why a table is a rational markup. It is not rational to me at all.

Labels refer to inputs in the for attribute
The form groups them together.
There is no new for rows / columns.
Comment 4 Tyler Romeo 2013-01-18 18:11:22 UTC
A table is perfectly rational markup. One column is for labels, the other column is for inputs, and each row is a field with its label.

However, if https://gerrit.wikimedia.org/r/27022 ever gets merged, you can always just call setDisplayFormat( 'div' ) on the HTMLForm to change it.
Comment 5 Juliusz Gonera 2013-01-18 18:45:55 UTC
A table is a rational markup, but not a flexible one. It makes sense on desktop but is not very suitable for mobile devices.

A <ul> or <dl> (or even bare <label> and <input>) can be styled to look like a table, but it's very difficult to make a table look like a list (especially on older browsers, or IE that Windows Phone uses).
Comment 6 Arthur Richards 2013-01-18 18:55:18 UTC
This is trivial enough to fix; see the mobile version of the create account form.
Comment 7 Jon 2013-01-18 22:18:04 UTC
My main groan with this is that it seems we are using a table markup just for the styling benefits it gives.

Mobile had to rewrite the login form from scratch due to this constraint.

I would advocate going for a bare label and input login form for the existing Special:UserLogin - there is no need for it to be in a table.
Comment 8 Tyler Romeo 2013-02-14 07:46:39 UTC

*** This bug has been marked as a duplicate of bug 34751 ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links