Last modified: 2013-10-23 18:17:19 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T36751, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 34751 - Replacing table layout in registration and login forms
Replacing table layout in registration and login forms
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
User login and signup (Other open bugs)
1.18.x
All All
: Normal normal (vote)
: 1.22.0 release
Assigned To: spage
: accessibility
: 43108 (view as bug list)
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-02-27 14:05 UTC by Kai Nissen
Modified: 2013-10-23 18:17 UTC (History)
12 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
patch for changing from table layout to CSS layout (18.04 KB, patch)
2012-02-27 14:05 UTC, Kai Nissen 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Kai Nissen 2012-02-27 14:05:52 UTC 
Created attachment 10114 [details]
patch for changing from table layout to CSS layout

The login and registration forms are using tables for laying out the page. I propose the attached patch to change it to CSS. The patch also includes the usage of methods (i. e. Html::element()) for creating the form fields instead of embedded HTML. The patch also removes the default type attributes' value to make sure the CSS-selector for "input type=text" is working.
Comment 1 Sumana Harihareswara 2012-02-27 14:44:01 UTC 
Thanks for the patch, Kai Nissen!  I've added keywords to indicate that this patch awaits review (see https://www.mediawiki.org/wiki/How_to_become_a_MediaWiki_hacker#Submit_your_changes ) and given you Bugzilla privileges so you can add those keywords in the future, if you need to.  Thanks again.
Comment 2 Kai Nissen 2012-02-27 15:14:17 UTC 
By the way, this bug has also been mentioned by the accessibility report that was carried out by the swiss foundation "access for all".

See paragraph 1.3.1.C1 and 1.3.1.D2 for details.
http://www.thirdageonline.eu/project-tao-2/software-development/mediawiki-accessibility-enhancements/
Comment 3 Mark A. Hershberger 2012-02-27 18:26:19 UTC 
Moar CSS!
Comment 4 Sumana Harihareswara 2012-02-27 20:16:31 UTC 
Lowered priority to Normal.
Comment 5 Max Semenik 2012-04-19 17:07:36 UTC 
We shouldn't add that much CSS to the file loaded on every request. Also, HTML generation code is scary (and presently, too) - it would make a lot of sense to migrate this stuff to HTMLForm (there are tentative plans to make it optionally not use tables).
Comment 6 Mark A. Hershberger 2012-09-30 16:48:52 UTC 
Obviously not being fixed in the 1.20 tarball.
Comment 7 Sumana Harihareswara 2012-10-12 02:19:11 UTC 
Marking reviewed per comment #5 -- Kai, would you be interested in revising and responding with a Gerrit changeset?  Thanks.
Comment 8 Tyler Romeo 2013-02-14 07:46:39 UTC 
*** Bug 43108 has been marked as a duplicate of this bug. ***
Comment 9 spage 2013-04-18 18:42:18 UTC 
MediaWiki 1.22wmf2 introduces mw-ui- CSS styles for a new vertical form layout. It's currently opt-in for login (try at http://www.mediawiki.org/w/index.php?title=Special:UserLogin&useNew=1 ).

(In reply to comment #5)
> it would make a lot of sense to migrate this stuff to HTMLForm
That remains to do (some initial work in Gerrit change #56058) so I'm leaving this bug open.
Comment 10 Marius Hoch 2013-08-19 15:47:34 UTC 
I guess we can resolve this one as the new form doesn't have this problem(s)?!
Comment 11 Tyler Romeo 2013-08-19 16:02:23 UTC 
Good point. Resolved.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links