Last modified: 2013-04-22 16:15:25 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T44366, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 42366 - Change the float of #p-personal list items to follow directionality of the page in Vector skin


Summary:	Change the float of #p-personal list items to follow directionality of the pa...

Status:	RESOLVED WORKSFORME

Product:	MediaWiki
Classification:	Unclassified
Component:	Internationalization (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Unprioritized normal (vote)
Target Milestone:	---
Assigned To:	Huji

URL:
Whiteboard:
Keywords:

Depends on:	42337
Blocks:	rtl
	Show dependency tree / graph

Reported:	2012-11-22 21:26 UTC by Huji
Modified:	2013-04-22 16:15 UTC (History)
CC List:	6 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Current behavior, vs expected behavior (3.07 KB, image/png) 2012-11-22 21:31 UTC, Huji	Details
Add an attachment (proposed patch, testcase, etc.)

Description Huji 2012-11-22 21:26:03 UTC

In order for the RTL layout to exactly mirror the LTR layout, when it comes to the portlets on the top of the page, the li's should float:right

Right now, they always float:left regardless of the directionality of the wiki.

In simple words, applying this rule to RTL pages fixes the problem:


#p-personal ul li {
    float: right;
}


It needs to be fixed in the Common.css

Comment 1 Huji 2012-11-22 21:31:52 UTC

Created attachment 11409 [details]
Current behavior, vs expected behavior

Attached image shows the current and expected behavior.

Comment 2 Siebrand Mazeland 2012-11-22 21:59:37 UTC

Gerrit change #34846

Comment 3 Amir E. Aharoni 2012-11-22 22:08:28 UTC

If I understand correctly, this is the same issue as Bug 42337. I committed a more comprehensive solution for it in https://gerrit.wikimedia.org/r/#/c/34849/ .

Comment 4 Huji 2012-11-22 23:43:22 UTC

This is related, if not identical. I'd like to wait for that one to be completed before we work on this one. Marking that as a blocker for this one.

Comment 5 Huji 2012-11-27 12:33:50 UTC

The latest fix for bug 42337 has fixed this bug as well.

Comment 6 Amir E. Aharoni 2012-11-27 12:39:23 UTC

The Gerrit commit should probably be abandoned.

But thanks a lot for the quick reaction.

Comment 7 Huji 2012-11-27 23:07:15 UTC

Done.

Note You need to log in before you can comment on or make changes to this bug.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links