Last modified: 2014-09-20 03:32:07 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T44008, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 42008 - Revert bug 27860 or add configuration variable to restore "Mark all edits minor by default" preference behaviour
Revert bug 27860 or add configuration variable to restore "Mark all edits min...
Status: NEW
Product: MediaWiki
Classification: Unclassified
Page editing (Other open bugs)
All All
: Normal major with 1 vote (vote)
: 1.23.x release
Assigned To: Nobody - You can work on this!
: code-update-regression, design
Depends on: 27860 40111
Blocks: 31567 Wikisource
  Show dependency treegraph
Reported: 2012-11-11 13:30 UTC by Nemo
Modified: 2014-09-20 03:32 UTC (History)
14 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Description Nemo 2012-11-11 13:30:52 UTC
(Doug wrote on bug 27860 comment #9)
> There was never any reason to make this change.  The correct change as noted by
> Nemo_bis, was to uncheck the box by default and possibly remove the option to
> change this to checked by default, not remove the box from new pages
> altogether.  Nobody ever really asked for that change; two alternatives were
> presented and one was simply implemented without comment as to why that was
> perceived as the better alternative.
> Additionally, the original problem was characterized as being for making a "New
> Section" not creating a page, a new section to an already existing page is
> actually less likely to be minor than a new page is.  This should be reverted
> unless there is a wiki that thinks it actually needs it to be turned on - that
> is that they never have minor page creations even for redirects - unless you're
> a bot, bots can still create new pages as minor.

The new behaviour of the preference must be triggered by a new configuration variable, false by default.
Target milestone 1.20.x as this catastrophic behaviour change for such an important preference should not affect more releases.
Comment 1 Andre Klapper 2012-11-12 11:55:59 UTC
This was committed 18 months ago - I don't see this as "high" priority suddenly.
Comment 2 Doug 2012-11-12 17:40:29 UTC
Not sure why it's not "high" priority suddenly, it has been sitting as "high" at Bug:27860 the whole time.  This is a very important issue that never should've been changed.
Comment 3 Andre Klapper 2013-01-01 12:17:25 UTC
So this would require design input, and a "yes" or "no".
Anybody willing to come up with arguments pro or con?
Comment 4 Andre Klapper 2013-03-21 14:44:01 UTC
bharris / vbamba / zhorishna: Any design input on this?
Comment 5 Isarra 2013-03-21 16:57:10 UTC
I'm not entirely sure what all this bug is referring to, but I certainly do agree with reverting the change it mentions in the summary. 

Hiding the option to mark something a minor edit is not helpful, especially on new pages which often are indeed minor edits - be they redirects, content containers, pointless user pages, or various other things depending on the project in question. Even new sections can be minor edits; that they usually aren't doesn't explain why the option should be removed entirely, but making the 'mark all edits minor by default' thing not apply to them would indeed have made sense.

While I personally believe that preferences option - the marking all edits minor by default - should really be a gadget instead on those projects that want to support it, I see no solid grounds to have removed the option to mark some things as minor entirely.
Comment 6 Andre Klapper 2014-02-26 12:12:51 UTC
[Removing "easy" keyword because discussion shows that it's controversial and hence nothing to start with for beginners who want to see their patches merged at some point.]
Comment 7 Laurence 'GreenReaper' Parry 2014-06-07 16:00:16 UTC
I got complaints about this just a day or so after upgrading WikiFur. People expect to be able to mark trivial page and redirect creations as minor.

Bug 40111 which removes this capability in the API may also need reverting.
Comment 8 Bawolff (Brian Wolff) 2014-09-19 21:19:27 UTC
Do people still strongly care about this issue/Want me to fix it (by fix I mean add a global to control what the preference does, probably defaulting to current behaviour)?

Asking because bug has been opened for a long time now...
Comment 9 Nemo 2014-09-19 21:24:24 UTC
Dunno what qualifies for "strongly care" but I still think this was very wrong and would love to have the checkboxes back, yes. :)
Comment 10 Laurence 'GreenReaper' Parry 2014-09-19 21:48:48 UTC
Yes, what Nemo said. 

I have a patch for this against 1.23 at:
It takes out $isNew entirely from EditPage.

The third chunk also lets edit summaries be blank for new pages even if they are generally required (since a good default is provided). I think this is a good change but you might want to remove it if addressing just this bug.
Comment 11 George Orwell III 2014-09-20 03:32:07 UTC
(In reply to Nemo from comment #9)
> Dunno what qualifies for "strongly care" but I still think this was very
> wrong and would love to have the checkboxes back, yes. :)

Ditto. :)

If this is found to be unreasonable (or the like) for some reason in moving forward, at the minimum I'd like to narrow the request and have the 'mark edit as minor' checkbox restored just for the Wikisource project(s) instead.

Note You need to log in before you can comment on or make changes to this bug.