Last modified: 2013-09-22 17:55:08 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T41992, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 39992 - ULS: Don't set inline "font-family: sans-serif" when no fonts are specified
ULS: Don't set inline "font-family: sans-serif" when no fonts are specified
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UniversalLanguageSelector (Other open bugs)
master
All All
: Normal major (vote)
: ---
Assigned To: Santhosh Thottingal
: design
Depends on:
Blocks: uls-deployment
  Show dependency treegraph
 
Reported: 2012-09-05 09:12 UTC by Niklas Laxström
Modified: 2013-09-22 17:55 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Niklas Laxström 2012-09-05 09:12:44 UTC
At http://tieteentermipankki.fi/wiki the ULS is overriding the font Georgia specified for #bodyContent with generic sans-serif font, even when no webfonts are used or available.
Comment 1 Krinkle 2012-10-13 06:29:14 UTC
When I navigate to https://translatewiki.net/w/i.php?title=Special:UserLogin

I always get this annoying tiny font in the username input field because ULS is setting inline style="font-family: sans-serif;" on the input field.
Comment 2 Amir E. Aharoni 2012-10-16 12:49:08 UTC
Fixed in https://gerrit.wikimedia.org/r/#/c/28200/ maybe?
Comment 3 Krinkle 2012-10-29 18:51:06 UTC
See also bug 39560. This is currently occurring on Wikidata.org.

By default users now have "font-family: sans-serif;" inline on the <textarea>
instead of the browser default (which in most browsers is a monospace font for
<textarea>).
Comment 4 Krinkle 2012-12-10 13:40:39 UTC
Also happening on sa.wikisource.org.

For example: https://sa.wikisource.org/w/index.php?title=MediaWiki:Gadget-AjaxPatrolLinks.js&action=edit

My default is a monospace font, but on that page I get a sans-serif font. Even if I press "Reset" it'll still enforce an inline style sans-serif.

It should reset it, not enforce it to sans-serif.
Comment 5 Niklas Laxström 2012-12-10 15:24:05 UTC
Krinkle: If it is happening on sa.wikisource.org it must be the WebFonts extension, not ULS.
Comment 6 Krinkle 2012-12-10 18:41:49 UTC
I lost track what is what, it seems to be migrating from one to another. AFAIK they are based on the same code. The bug is in both.
Comment 7 Siebrand Mazeland 2013-01-02 15:21:03 UTC
Fixed in Gerrit change #35596.
Comment 8 Niklas Laxström 2013-01-02 15:44:11 UTC
Patch Set 2: There's a problem with this change, please improve
Claims to fix bug 39992 but it doesn't, unless you specifically disable all webfont loading and refresh the page.
Comment 9 Santhosh Thottingal 2013-05-29 09:42:57 UTC
Retested this. If the user has an  'editfont' preference, we will exclude the editable areas from applying webfont. Also, if the user preference is 'system' for the current UI language, we will exclude.

There is a bug when resetting the font to system, instead of leaving the textarea untouched, currently it set sans-serif font explicitly.- to be fixed.
Comment 10 Santhosh Thottingal 2013-05-29 10:19:43 UTC
(In reply to comment #9)
> There is a bug when resetting the font to system, instead of leaving the
> textarea untouched, currently it set sans-serif font explicitly.- to be
> fixed.

Ic3baa18b01a972f08e51e84217e82d0939e674c0 and Iff522e0016d8284dc785580e6eb3dd2967c58289 will address this.
Comment 11 Niklas Laxström 2013-05-29 10:29:19 UTC
I see style="font-family: sans-serif;" on body now.
Comment 12 Santhosh Thottingal 2013-05-29 10:55:47 UTC
sans-serif is the default font-family value for body, even if ULS extension is not used.
Comment 13 Niklas Laxström 2013-05-29 12:06:34 UTC
Yes, but with ULS it is appearing as inline-style which overrides other defined styles.
Comment 14 Gerrit Notification Bot 2013-05-30 11:08:58 UTC
Related URL: https://gerrit.wikimedia.org/r/66084 (Gerrit Change Ifd8c4629f5512f6d54fc0a19d3b8d2bec4db23c0)
Comment 15 Santhosh Thottingal 2013-06-03 06:07:24 UTC
patch was merged

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links