Last modified: 2013-09-05 17:40:28 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T41560, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 39560 - Monospace font setting overridden
Monospace font setting overridden
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UniversalLanguageSelector (Other open bugs)
master
All All
: High normal (vote)
: ---
Assigned To: Amir E. Aharoni
https://translatewiki.net/w/i.php?tit...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-08-22 13:12 UTC by Siebrand Mazeland
Modified: 2013-09-05 17:40 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Siebrand Mazeland 2012-08-22 13:12:02 UTC
As reported on twn:

"Since yesterday, the edit window have used proportional font (“font-family: Helvetica,Arial,sans-serif”), set directly on the element using a JS somewhere, so that it is difficult to find the specific cause. I suspect WebFonts are somehow to blame here, but I’m not sure about that. Anyway – is this a feature, or a bug, and can I have the monospaced font back, please? (Changing the font in preferences does not work, since that just emits a CSS rule for textarea, which is overriden by a specific style declaration directly on the element, set by the JS.)"

Santhosh confirmed this issue.
Comment 1 Srikanth Logic 2012-08-28 13:16:14 UTC
Fixed in https://gerrit.wikimedia.org/r/#/c/21411/
Comment 2 Santhosh Thottingal 2012-08-28 13:25:42 UTC
https://gerrit.wikimedia.org/r/#/c/21411/ will not fix this completely, Still there are two font preferences - one from ULS and one from existing mediawiki preferences. Both will conflict each other for edit boxes. So we need a better way to handle these two options. But I think priority can be reduced with this fix.
Comment 3 Mormegil 2012-08-31 15:32:16 UTC
The bug is back again. Only this time, the style attribute says only "font-family: sans-serif;"
Comment 4 Santhosh Thottingal 2012-09-05 08:23:09 UTC
Fixed in gerrit I5c35c848
Comment 5 Santhosh Thottingal 2012-10-16 10:05:04 UTC
Some regression caused this again.
Comment 6 Amir E. Aharoni 2012-10-18 10:49:43 UTC
Fix submitted in
https://github.com/wikimedia/jquery.webfonts/pull/2
Comment 7 Krinkle 2012-10-29 18:50:42 UTC
See also bug 39992. This is currently occurring on Wikidata.org.

By default users now have "font-family: sans-serif;" inline on the <textarea> instead of the browser default (which in most browsers is a monospace font for <textarea>).

The MediaWiki preference related to this is not relevant, as it doesn't do anything by default.
Comment 8 Mormegil 2013-09-04 09:55:23 UTC
…and here we go again. The textarea on MediaWiki.org has “font-family: sans-serif;” style inline when using Czech [cs], see e.g. http://www.mediawiki.org/w/index.php?title=Project:Sandbox&action=edit&uselang=cs

My guess is I9dd87f44 (or https://github.com/santhoshtr/jquery.webfonts/commit/1f67cf2bf9ac435a6772eb66f080b118c0e10661).

I switched my preferences to make the textarea always use monospaced font, which seems to stop ULS from messing with the textarea for now.
Comment 9 Nemo 2013-09-05 17:40:28 UTC
Mormegil, if you don't mind I suggest to keep this old report closed and continue on bug 53734 which is its reincarnation.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links