Last modified: 2012-09-05 23:49:40 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 39959 - Right click to edit section causing browser hangs
Right click to edit section causing browser hangs
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
JavaScript (Other open bugs)
unspecified
All All
: Normal major (vote)
: Future release
Assigned To: Krinkle
:
Depends on:
Blocks: 39972
  Show dependency treegraph
 
Reported: 2012-09-04 02:46 UTC by Ryulong
Modified: 2012-09-05 23:49 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
screenshot of firebug (97.75 KB, image/png)
2012-09-04 11:36 UTC, Derk-Jan Hartman
Details

Description Ryulong 2012-09-04 02:46:36 UTC
As of the past couple of days, I've been experiencing an issue with the "right click to edit section" option in the preferences. Upon right clicking, the browser completely freezes up and it takes much longer to open up the editting window. Once the edit window loads, the browser is completely usable again. I've attempted this in FireFox and Chrome (Chrome had a shorter lag), and I've had the issue in FireFox in Safe Mode (no add ons at all active).
Comment 1 MZMcBride 2012-09-04 03:23:50 UTC
In the editing tab of Special:Preferences (<https://en.wikipedia.org/wiki/Special:Preferences#mw-prefsection-editing>), there's a user preference labeled "Enable section editing by right clicking on section titles (requires JavaScript)".

I think this user preference's JavaScript is the culprit of a few issues reported today regarding unresponsive script errors, maybe (cf. <https://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_(technical)&oldid=510691366>).
Comment 2 Ryulong 2012-09-04 06:45:05 UTC
I've just discovered that right clicking ANYTHING on Wikipedia is producing this error. It is taking way too long to open up the right click dialogue.
Comment 3 Oliver Keyes 2012-09-04 11:06:22 UTC
Same here. What on earth?
Comment 4 Derk-Jan Hartman 2012-09-04 11:36:30 UTC
Created attachment 11064 [details]
screenshot of firebug

Seems like it's another issue in jquery 1.8.*

This time on FF 15, it is stuck in tokenize of Sizzle. Triggered initially by the selector:

"h1:has(.editsection a), h2:has(.editsection a), h3:has(.editsection a), h4:has(.editsection a), h5:has(.editsection a), h6:has(.editsection a)" of the right click editor.
Comment 5 Krinkle 2012-09-04 17:26:10 UTC
(In reply to comment #4)
> Created attachment 11064 [details]
> screenshot of firebug
> 
> Seems like it's another issue in jquery 1.8.*
> 
> This time on FF 15, it is stuck in tokenize of Sizzle. Triggered initially by
> the selector:
> 
> "h1:has(.editsection a), h2:has(.editsection a), h3:has(.editsection a),
> h4:has(.editsection a), h5:has(.editsection a), h6:has(.editsection a)" of the
> right click editor.

Works fine in Chrome 21 and Firefox 15 here. Running MediaWiki in localhost, with jQuery 1.8.1 and right-click-edit-js enabled (commit right before t he revert).

Define "stuck" ?
Comment 6 Derk-Jan Hartman 2012-09-04 17:59:09 UTC
FF 15. "Warning: Unresponsive script. A script on this page may be busy, or it may have stopped responding. You can stop the script now, or you can continue to see if the script will complete."

It doesn't happen all the time, but quite often. It seems to loop somewhere in the selector parsing.
Comment 7 Krinkle 2012-09-04 19:50:34 UTC
Fixed in I2fefb5376d0de40f4997a3a1763eee23fcd3e7fa

(by no longer using the :has() selector in a .live() handler, which were very two slow factors combined)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links