Last modified: 2014-04-08 08:58:34 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T41357, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 39357 - Pressing ENTER on editbox should not submit the search form
Pressing ENTER on editbox should not submit the search form
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
WikiEditor (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: javascript
Depends on:
Blocks: 63665
  Show dependency treegraph
 
Reported: 2012-08-14 23:29 UTC by Helder
Modified: 2014-04-08 08:58 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Helder 2012-08-14 23:29:44 UTC
Now that the bug 24566 was fixed by Gerrit change #17654, a new bug became visible: "for some reason, if I open the search and replace dialog, find something and then I click on the edit box and press ENTER it submit the search dialog instead of adding a new line."
Comment 1 Derk-Jan Hartman 2012-08-15 20:23:49 UTC
logical:

                                                  $( textbox )
                                                        .bind( 'keypress.srdialog', function ( e ) {
                                                                if ( e.which == 13 ) {
                                                                        // Enter
                                                                        var button = dialog.data( 'dialogaction' ) || dialog.find( 'button:first' );
                                                                        button.click();
                                                                        e.preventDefault();
                                                                } else if ( e.which == 27 ) {
                                                                        // Escape
                                                                        $(that).dialog( 'close' );
                                                                }
                                                        });

Now to solve it...
Comment 2 Derk-Jan Hartman 2012-08-15 21:59:45 UTC
This is one idea:

https://gerrit.wikimedia.org/r/19942
Comment 3 Derk-Jan Hartman 2012-08-15 22:03:32 UTC
probably better to this with exact match.
Comment 4 Gerrit Notification Bot 2013-07-01 13:42:04 UTC
Change 19942 abandoned by TheDJ:
Enter in editbox should not submit Search dialog

https://gerrit.wikimedia.org/r/19942
Comment 5 Derk-Jan Hartman 2013-07-01 13:42:36 UTC
Change abandoned after 11 months.
Comment 6 Andre Klapper 2013-07-01 14:03:55 UTC
(In reply to comment #5)
> Change abandoned after 11 months.

For which reason? No answer on your last commit in Gerrit and frustration, or are there actually technical reasons?
Comment 7 Derk-Jan Hartman 2014-04-07 16:31:09 UTC
ehm, probably :)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links