Last modified: 2014-04-08 08:58:34 UTC
Now that the bug 24566 was fixed by Gerrit change #17654, a new bug became visible: "for some reason, if I open the search and replace dialog, find something and then I click on the edit box and press ENTER it submit the search dialog instead of adding a new line."
logical: $( textbox ) .bind( 'keypress.srdialog', function ( e ) { if ( e.which == 13 ) { // Enter var button = dialog.data( 'dialogaction' ) || dialog.find( 'button:first' ); button.click(); e.preventDefault(); } else if ( e.which == 27 ) { // Escape $(that).dialog( 'close' ); } }); Now to solve it...
This is one idea: https://gerrit.wikimedia.org/r/19942
probably better to this with exact match.
Change 19942 abandoned by TheDJ: Enter in editbox should not submit Search dialog https://gerrit.wikimedia.org/r/19942
Change abandoned after 11 months.
(In reply to comment #5) > Change abandoned after 11 months. For which reason? No answer on your last commit in Gerrit and frustration, or are there actually technical reasons?
ehm, probably :)