Last modified: 2012-08-14 20:35:38 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T26566, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 24566 - Search and replace dialog should not be modal
Search and replace dialog should not be modal
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikiEditor (Other open bugs)
unspecified
All All
: Normal major with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
: javascript, patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-07-28 10:26 UTC by Platonides
Modified: 2012-08-14 20:35 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Platonides 2010-07-28 10:26:58 UTC
Search and replace dialog appears modal over the page, which gets obscured. This means among other things that the user cannot change the textarea while the dialog is open.

This is not a problem for Replace all, but when the user is doing find next / replace next, the text is hard to view, and cannot be scrolled or unmodified (to back out one replace next, change the focus to skip the point where it continues...).
Comment 1 Roan Kattouw 2010-08-03 20:27:08 UTC
Adam, maybe you could play with making the dialog non-modal?
Comment 2 Krinkle 2011-06-22 00:29:12 UTC
*Mass-change: Move WikiEditor bugs to component and remove blocker bug where*
Comment 3 Helder 2011-08-01 14:25:44 UTC
Still no progress on this?

How is the user supposed to do repetitive changes to wikipages?
* The tool doesn't let him to edit the page without closing the box;
* If he close it, then the text which was selected by the search box won't be selected anymore;
* If he uses "Replace all" instead, then the browser hungs up because of its slowness? (bug 23510)
These problems adds lots of unnecessary clicks to these kind of tasks which the 'search and replace' feature is supposed to help editors with.
Comment 4 Thehelpfulone 2012-06-22 19:45:16 UTC
Reassign to default per bug 37789
Comment 5 Derk-Jan Hartman 2012-08-04 14:17:44 UTC
Done in https://gerrit.wikimedia.org/r/17654
Comment 6 Derk-Jan Hartman 2012-08-04 14:19:16 UTC
Anyone have a smart CSS check to differentiate between modal and non modal jquery dialogs ? Cause we might want to add a black border around that dialog to raise contrast a bit.
Comment 7 Roan Kattouw 2012-08-14 20:35:38 UTC
(In reply to comment #5)
> Done in https://gerrit.wikimedia.org/r/17654
Merged.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links