Last modified: 2012-05-04 13:12:01 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T38340, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 36340 - Please preserve paragraph directionality in diff
Please preserve paragraph directionality in diff
Status: NEW
Product: MediaWiki
Classification: Unclassified
History/Diffs (Other open bugs)
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
Depends on:
Blocks: 738 rtl
  Show dependency treegraph
Reported: 2012-04-29 17:28 UTC by kipod
Modified: 2012-05-04 13:12 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Description kipod 2012-04-29 17:28:10 UTC
(this is most meaningful for RTL wikis, but probably good for all)
The new diff introduced in 1.20 is great. however, it would be even better if the diff section would use the same directionality (aka "bidi", aka "ltr/rtl") as the paragraph being compared.

specifically, all RTL wikis contain significant pieces in ltr, and the diff is way less useful when it does not respect the directionality of the segment being compared.

Comment 1 Mark A. Hershberger 2012-05-01 19:53:32 UTC
Another blocker for Bug #745! w00!
Comment 2 Robin Pepermans (SPQRobin) 2012-05-01 20:00:13 UTC
It is only possible to know the direction of the page content (thanks to the page content language) but it's not possible to know the direction of a specific section. Unless we use dir="auto" but I'm not sure that would be good.
Comment 3 Amir E. Aharoni 2012-05-01 20:09:23 UTC
As Robin says, this is one of those bugs that would be solved if MediaWiki would treat paragraphs and sections as real objects and not as parts of a big blob, which is the whole page's wikitext. You know, like one of the best-known three-digit bugs, Bug 738.

It may get solved in the Bright Future Days of the Visual Editor, if the bidirectional requirements that I (and Robin) wrote are implemented:

dir="auto" is probably not that good. To begin with, it will treat all paragraphs that begin with an HTML tag as ltr.
Comment 4 kipod 2012-05-01 23:32:14 UTC
FWIW, i added to my common.js the following line, which makes the little "+" or "-" marker of the diff an rtl/ltr toggle:

$(function(){$('td.diff-marker').click(function(){var next=$(this).next(),dir=next.css('direction');next.css('direction', (dir=='rtl')?'ltr':'rtl');})});

i still think it shouldn't be impossible to utilize the parser API, maybe  together with jquery, so we can deduce the directionality of the paragraph or section.


Note You need to log in before you can comment on or make changes to this bug.