Last modified: 2014-01-03 16:09:21 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T38325, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 36325 - Direction (ltr/rtl) of feedback comments may be different from the direction of the interface language
Direction (ltr/rtl) of feedback comments may be different from the direction ...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
ArticleFeedbackv5 (Other open bugs)
unspecified
All All
: Low normal (vote)
: ---
Assigned To: Matthias Mullie
: i18n
Depends on:
Blocks: rtl
  Show dependency tree / graph
 
Reported: 2012-04-28 20:09 UTC by Amir E. Aharoni
Modified: 2014-01-03 16:09 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Amir E. Aharoni 2012-04-28 20:09:02 UTC 
When the direction of the interface language is different from the direction of the site content, the feedback comments will likely appear with incorrect direction. I refer to the <blockquote> in which there is a <span> with class="articleFeedbackv5-comment-short".

This scenario is rare, but possible.

There are several possible solutions:

1. Apply dir="auto" to the <blockquote>. It will work only in Gecko and Webkit and it will work incorrectly in some cases, but should be more flexible.

2. Apply the direction of the site's language to the <blockquote>. This will work in all browsers, but may be incorrect if the comment was written in a language, the directionality of which is different from the directionality of the site.
Comment 1 Gerrit Notification Bot 2013-05-08 12:32:06 UTC 
Related URL: https://gerrit.wikimedia.org/r/62807 (Gerrit Change Ifd7c812637bd31e1bbb5784969030fa403efb22f)
Comment 2 Andre Klapper 2013-07-23 08:56:20 UTC 
Amir: Could you review Matthias' one-liner patch in Gerrit?
Comment 3 Andre Klapper 2013-10-18 19:09:16 UTC 
Amir: Could you review Matthias' one-liner patch in Gerrit?
Comment 4 Andre Klapper 2013-11-19 16:57:33 UTC 
Amir: Could you review Matthias' one-liner patch in Gerrit?
Comment 5 Gerrit Notification Bot 2013-12-15 16:05:50 UTC 
Change 62807 merged by jenkins-bot:
(bug 36325) Direction (ltr/rtl) of feedback comments may be different from the direction of the interface language

https://gerrit.wikimedia.org/r/62807
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links