Last modified: 2012-04-12 11:37:23 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T37871, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 35871 - Jenkins should not accept PHP files with spurious output (without <?php)
Jenkins should not accept PHP files with spurious output (without <?php)
Status: RESOLVED WONTFIX
Product: Wikimedia
Classification: Unclassified
Git/Gerrit (Other open bugs)
unspecified
All All
: High normal (vote)
: ---
Assigned To: Antoine "hashar" Musso (WMF)
https://gerrit.wikimedia.org/r/#patch...
:
Depends on:
Blocks: 35585
  Show dependency tree / graph
 
Reported: 2012-04-10 23:52 UTC by Marcin Cieślak
Modified: 2012-04-12 11:37 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Marcin Cieślak 2012-04-10 23:52:32 UTC 
I was surprised to see that Jenkins run https://integration.mediawiki.org/ci/job/MediaWiki-GIT-Fetching/588/console passed. (I understand there were no tests run yet, though).

This was introduced by this change:

https://gerrit.wikimedia.org/r/#patch,unified,4672,2,includes/db/DatabasePostgres.php
Comment 1 Mark A. Hershberger 2012-04-11 20:39:05 UTC 
this would be a good place to put some "lint" like checks.  Hrm... and this really isn't Git or Gerrit.
Comment 2 Antoine "hashar" Musso (WMF) 2012-04-12 11:37:23 UTC 
As a summary, the change replaced a '<?php' by '19php'. The end result is that all the file content is interpreted as a full text file making all the file content looking perfectly legit to PHP linter.

I am going to wont fix this issue:
- I believe most syntax highlighter will choke over that kind of change.
- people testing their change will surely have their local wiki to choke on it
- it is a rare corner case
- It is surely going to crash any test suite that rely on postgre (they are not run yet though on jenkins).
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links