Last modified: 2013-04-09 21:00:12 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T37585, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 35585 - Jenkins: Set up linting for php, js, py etc. (tracking)
Jenkins: Set up linting for php, js, py etc. (tracking)
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Continuous integration (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Krinkle
:
Depends on: 35871 42628
Blocks: tracking 35584
  Show dependency treegraph
 
Reported: 2012-03-29 15:28 UTC by Antoine "hashar" Musso (WMF)
Modified: 2013-04-09 21:00 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Antoine "hashar" Musso (WMF) 2012-03-29 15:28:46 UTC
We need a Jenkins job able to lint the various languages and formats in use:
 - PHP
 - JavaScript
 - CSS
And then optionally extended to, for usage outside of MediaWiki:
 - python
 - java

Could be named the universal linting job.
Comment 1 Krinkle 2012-04-26 19:34:04 UTC
Per bug 34617 comment 3, we should also make this available for other repositories. I propose the following:

* Set up a Jenkins child-project of "MediaWiki core GIT" that runs the linter as part of the larger workflow
* Set up a Jenkins project that does the same, but is triggered on all gerrit-hosted git repos (including extensions, and operations etc., except for mediawiki/core which has its own dedicated job in Jenkins).
Comment 2 Antoine "hashar" Musso (WMF) 2012-12-02 17:18:13 UTC
Adding two dependencies:

Bug 38233 - Jenkins: fail on BOM in submitted files
Bug 42628 - fail on whitespace error in submitted files
Comment 3 Krinkle 2013-04-09 20:59:49 UTC
(In reply to comment #2)
> Adding two dependencies:
> 
> Bug 38233 - Jenkins: fail on BOM in submitted files

Removing as it isn't really linting of a programming language. We can implement it in a linting job, but not blocking the universal linter.

And on that subject, we no longer have the model of universal linter, we have separate jobs. Though there are still somethings not covered, we cover pretty much everything now:

* php -l
* jshint
* pep8
* puppet validate
* ..

I'm marking this fixed. For other linters, we can just open op individual issues.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links