Last modified: 2013-10-23 15:56:17 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T36800, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 34800 - Keep classes such as "diff-addedline" and "diff-deletedline" on diffs on RSS feeds
Keep classes such as "diff-addedline" and "diff-deletedline" on diffs on RSS ...
Status: NEW
Product: MediaWiki
Classification: Unclassified
History/Diffs (Other open bugs)
1.19
All All
: Low enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: easy
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-02-29 17:35 UTC by Helder
Modified: 2013-10-23 15:56 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Helder 2012-02-29 17:35:33 UTC
Currently, the content of RSS feeds such as
https://pt.wikipedia.org/w/index.php?title=Special:RecentChanges&feed=rss&action=purge
includes the classes
* diff
* diff-contentalign-left
* diff-marker
* diff-content
* diff-lineno
* diff-empty
* diffchange
* diffchange-inline
On the other hand, the other classes which are present on the wiki pages are removed from RSS feeds, making it difficult for the users to customize the styling of these diffs if they want to do so.

The classes
* diff
* diff-otitle
* diff-ntitle
* diff-addedline
* diff-deletedline
* diff-context
* diffchange
shouldn't be removed by function applyDiffStyle from
http://svn.wikimedia.org/viewvc/mediawiki/branches/REL1_18/phase3/includes/FeedUtils.php?view=markup#l174
The styles should just be copied to the elements, without removing the classes.

Besides, the regex used to detect the classes doesn't match the "diff" and "diffchange" classes. I'll open another bug specifically about that.

See also bug 34798.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links