Last modified: 2014-09-24 01:21:33 UTC
The formatting defined at http://svn.wikimedia.org/viewvc/mediawiki/branches/REL1_18/phase3/resources/mediawiki.action/mediawiki.action.history.diff.css?view=markup#l17 is replicated at http://svn.wikimedia.org/viewvc/mediawiki/branches/REL1_18/phase3/includes/FeedUtils.php?view=markup#l163 but the new formatting (from r107127 / r109932 ) defined at http://svn.wikimedia.org/viewvc/mediawiki/branches/REL1_19/phase3/resources/mediawiki.action/mediawiki.action.history.diff.css?view=markup#l18 is out of sync with http://svn.wikimedia.org/viewvc/mediawiki/branches/REL1_19/phase3/includes/FeedUtils.php?view=markup#l183 Please keep the same formatting in both places.
While you are at it, see also bug 34800 and bug 34801.
Let's clean this up for release, but this shouldn't be a deployment blocker.
updating milestones
mybugs, thanks for the hints on how to fix this! Added to https://www.mediawiki.org/wiki/Annoying_little_bugs#Defects_to_fix .
Updated links, now that use use Git/Gerrit instead of SVN: (In reply to comment #0) > The formatting defined at > http://svn.wikimedia.org/viewvc/mediawiki/branches/REL1_18/phase3/resources/ > mediawiki.action/mediawiki.action.history.diff.css?view=markup#l17 https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;a=blob;f=resources/mediawiki.action/mediawiki.action.history.diff.css;h=31ca10781cf5310cf947c8f1857a1905b06258e6;hb=HEAD#l51 > is replicated at > http://svn.wikimedia.org/viewvc/mediawiki/branches/REL1_18/phase3/includes/ > FeedUtils.php?view=markup#l163 https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;a=blob;f=includes/FeedUtils.php#l242
Patch in gerrit: Icbfb6cfc by Rahul21.
Patch merged.
As you can check using [[User:Lupin/Anti-vandal tool]], the style of the some elements is still different from what they should be, because applyDiffStyle doesn't copy the styles of nested selectors such as td.diff-addedline .diffchange, td.diff-deletedline .diffchange { border-radius: 0.33em; padding: 0.25em 0; } td.diff-addedline .diffchange { background: #d8ecff; } td.diff-deletedline .diffchange { background: #feeec8; } which are defined at https://git.wikimedia.org/blob/mediawiki%2Fcore.git/HEAD/resources%2Fmediawiki.action%2Fmediawiki.action.history.diff.css See also [[User_talk:Lupin/Anti-vandal_tool#Red_coloring_in_diff_display]]