Last modified: 2014-09-24 01:21:33 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T36798, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 34798 - Diffs on recent changes feed should have the same formatting of the on wiki diffs
Diffs on recent changes feed should have the same formatting of the on wiki d...
Status: REOPENED
Product: MediaWiki
Classification: Unclassified
Recent changes (Other open bugs)
1.22.0
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: easy
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-02-29 16:50 UTC by Helder
Modified: 2014-09-24 01:21 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Comment 1 Helder 2012-02-29 17:50:45 UTC
While you are at it, see also bug 34800 and bug 34801.
Comment 2 Rob Lanphier 2012-02-29 20:47:06 UTC
Let's clean this up for release, but this shouldn't be a deployment blocker.
Comment 3 Mark A. Hershberger 2012-10-01 17:31:49 UTC
updating milestones
Comment 4 Sumana Harihareswara 2012-12-09 18:19:21 UTC
mybugs, thanks for the hints on how to fix this! Added to https://www.mediawiki.org/wiki/Annoying_little_bugs#Defects_to_fix .
Comment 6 Bartosz Dziewoński 2013-02-17 18:35:53 UTC
Patch in gerrit: Icbfb6cfc by Rahul21.
Comment 7 Nischay Nahata 2013-03-09 16:34:50 UTC
Patch merged.
Comment 8 Helder 2013-10-23 16:12:51 UTC
As you can check using [[User:Lupin/Anti-vandal tool]], the style of the some elements is still different from what they should be, because applyDiffStyle doesn't copy the styles of nested selectors such as
td.diff-addedline .diffchange,
td.diff-deletedline .diffchange {
   border-radius: 0.33em;
   padding: 0.25em 0;
}
 
td.diff-addedline .diffchange {
   background: #d8ecff;
}
 
td.diff-deletedline .diffchange {
   background: #feeec8;
}
which are defined at
https://git.wikimedia.org/blob/mediawiki%2Fcore.git/HEAD/resources%2Fmediawiki.action%2Fmediawiki.action.history.diff.css


See also [[User_talk:Lupin/Anti-vandal_tool#Red_coloring_in_diff_display]]

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links