Last modified: 2013-04-22 16:17:03 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T36386, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 34386 - Enable e-mailing password based on e-mail address on Wikimedia wikis
Enable e-mailing password based on e-mail address on Wikimedia wikis
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Site requests (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Umherirrender
: easy, schema-change, shell
: 36656 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-02-14 06:15 UTC by Matthew Flaschen
Modified: 2013-04-22 16:17 UTC (History)
13 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Matthew Flaschen 2012-02-14 06:15:17 UTC
Please enable the new feature to email passwords based on email on the WMF wikis.

If I understand bug 13015 and the code correctly, this requires running patch-user_email_index.sql and setting $wgPasswordResetRoutes['username'] to true.

I think this will help keep sporadic editors and readers.  I know I've sometimes forgotten usernames (on non-WMF sites).  Right now, we tell such users we can't help them (http://en.wikipedia.org/wiki/Wikipedia:Contact_us/login_problems).
Comment 1 Matthew Flaschen 2012-02-14 16:56:44 UTC
I have posted this at the English Wikipedia Village Pump (http://en.wikipedia.org/wiki/Wikipedia:Village_pump_%28technical%29#.22Forgot_my_password.22_from_email).
Comment 2 Umherirrender 2012-06-27 16:27:35 UTC
You have to set

$wgPasswordResetRoutes['email'] = true;

to enable this feature, after adding the index.

It is possible to get the index? Thanks.
Comment 3 Umherirrender 2012-07-05 16:11:15 UTC
It is possible to get the index? Thanks.
Comment 4 Sam Reed (reedy) 2012-07-06 16:20:05 UTC
Asher, I guess this is doable (though, isn't going to be quick!). Would you be able to arrange to get this sorted?


CREATE INDEX /*i*/user_email ON /*_*/user (user_email(50));


Do you want an RT ticket creating?
Comment 5 Sam Reed (reedy) 2012-07-07 20:33:28 UTC
Also, I wonder if we need to put this index onto the CentralAuth globaluser.gu_email, and as such, add the functionality to CA and allow it to be used if needed
Comment 6 Umherirrender 2012-07-08 15:26:10 UTC
(In reply to comment #5)
> Also, I wonder if we need to put this index onto the CentralAuth
> globaluser.gu_email, and as such, add the functionality to CA and allow it to
> be used if needed

A global account has always the same email in all wikis, so this should not be a problem, when the email stored in the local user table is the same than the global email. If in the local user table another email is stored, this feature will not work properly (I am not sure, if CentralAuth updates (all) emails on the local wikis or is only changing it with a hook, when loading a user object)
Comment 7 Umherirrender 2012-07-13 17:51:17 UTC
(In reply to comment #4)
> Do you want an RT ticket creating?

Has somebody create a RT ticket?
Comment 8 Umherirrender 2012-07-20 16:12:30 UTC
One week is over, has somebody created a RT ticket?
Comment 9 Umherirrender 2012-07-27 18:50:00 UTC
Next week is over, has somebody created a RT ticket?
Comment 10 Umherirrender 2012-08-03 13:34:29 UTC
Next week is over, exist a RT ticket?
Comment 11 Umherirrender 2012-08-12 16:49:28 UTC
Next week is over, exist a RT ticket?

Asher, has you time to do this? Thanks.
Comment 12 Umherirrender 2012-08-20 19:29:18 UTC
Next week is over.

It is possible to get a comment, if this can be done and maybe when this is done? Thanks.
Comment 13 MZMcBride 2012-08-20 23:50:32 UTC
Hi Umherirrender. I'll have an answer for you shortly.
Comment 14 Betacommand 2012-08-20 23:53:35 UTC
How does this handle multiple accounts with the same email?
Comment 15 Sam Reed (reedy) 2012-08-20 23:59:32 UTC
(In reply to comment #14)
> How does this handle multiple accounts with the same email?

I guess it'd just use the first it finds.. I'm not sure what other sites do.
Comment 18 Asher Feldman 2012-08-21 01:57:18 UTC
I should have the user.user_email index applied to all projects within 24 hours of now.
Comment 19 Sam Reed (reedy) 2012-08-21 23:23:31 UTC
(In reply to comment #5)
> Also, I wonder if we need to put this index onto the CentralAuth
> globaluser.gu_email, and as such, add the functionality to CA and allow it to
> be used if needed

Turns out there already was one anyway in the CA schema file:

key (gu_email),

And it's already on the cluster too
Comment 20 MZMcBride 2012-08-21 23:26:40 UTC
(In reply to comment #18)
> I should have the user.user_email index applied to all projects within 24 hours
> of now.

I just want to say that you're wonderful and thank you.
Comment 21 Asher Feldman 2012-08-22 00:02:29 UTC
Migrations completed for all projects.  Thanks to Reedy for emailing me directly, I completely missed this ticket originally :)
Comment 22 Umherirrender 2012-08-22 16:46:55 UTC
Thanks for applying the index to all projects.

Next step is to change the config to enable the new feature.
The following line is needed:

$wgPasswordResetRoutes['email'] = true;

Thanks.
Comment 23 MZMcBride 2012-08-23 01:25:55 UTC
(In reply to comment #22)
> Thanks for applying the index to all projects.
> 
> Next step is to change the config to enable the new feature.
> The following line is needed:
> 
> $wgPasswordResetRoutes['email'] = true;
> 
> Thanks.

Do you have a Git/Gerrit account? I believe you can submit a changeset for this nowadays and then ask for it to be merged.
Comment 24 Umherirrender 2012-08-24 14:31:40 UTC
(In reply to comment #23)
> (In reply to comment #22)
> > Thanks for applying the index to all projects.
> > 
> > Next step is to change the config to enable the new feature.
> > The following line is needed:
> > 
> > $wgPasswordResetRoutes['email'] = true;
> > 
> > Thanks.
> Do you have a Git/Gerrit account? I believe you can submit a changeset for this
> nowadays and then ask for it to be merged.

I have a account, but not a clone of the config repo.

Now done with Gerrit change #21326
Comment 25 Dereckson 2012-08-24 15:05:19 UTC
Bug assigned to code submitter.
Comment 26 Umherirrender 2012-08-31 15:24:02 UTC
*** Bug 36656 has been marked as a duplicate of this bug. ***
Comment 27 Umherirrender 2012-09-05 15:39:20 UTC
config change is successfully merged

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links