Last modified: 2014-06-19 21:10:34 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T36153, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 34153 - Don't send email notifications upon translation review
Don't send email notifications upon translation review
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Translate (Other open bugs)
unspecified
All All
: Low normal (vote)
: ---
Assigned To: Nemo
:
: 54142 66335 (view as bug list)
Depends on: 42457 42458 14901
Blocks: hackathon2014
  Show dependency tree / graph
 
Reported: 2012-02-02 10:34 UTC by Nemo
Modified: 2014-06-19 21:10 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Ugly hack (572 bytes, patch)
2012-12-09 21:39 UTC, Niklas Laxström 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Nemo 2012-02-02 10:34:51 UTC 
It's a bit excessive to send an enotif for each translation review of a message in your watchlist: it potentially means to receive an email for each edit performed. It's useful to look into it if you translation was incorrect (and why), less if it was correct.
It could be an additional preference, but as far as I know recent changes patrol and flagged revisions actions (which apply to single revision/edits too) don't trigger any.
Comment 1 Sumana Harihareswara 2012-12-09 16:40:54 UTC 
Dan, do you feel like taking a crack at this?
Comment 2 Niklas Laxström 2012-12-09 21:39:38 UTC 
Created attachment 11483 [details]
Ugly hack

Here is a patch I've been using in translation sprints. Of course it is not good enough as-is for merge.
Comment 3 Dan Nessett 2012-12-10 04:43:00 UTC 
(In reply to comment #1)
> Dan, do you feel like taking a crack at this?

No, sorry. I am no longer active in MW development, having dramatically reduced the amount of time I contribute to CZ (which was the reason I worked on MW bugs in the first place) in order to spend more time on other interests.
Comment 4 Nemo 2013-09-15 18:11:09 UTC 
*** Bug 54142 has been marked as a duplicate of this bug. ***
Comment 5 Gerrit Notification Bot 2014-05-10 08:59:00 UTC 
Change 132615 had a related patch set uploaded by Nemo bis:
Don't send email notifications upon translation review

https://gerrit.wikimedia.org/r/132615
Comment 6 Gerrit Notification Bot 2014-06-19 09:04:08 UTC 
Change 132615 merged by jenkins-bot:
Don't send email notifications upon translation review

https://gerrit.wikimedia.org/r/132615
Comment 7 Nemo 2014-06-19 09:05:08 UTC 
Approved! Hopefully enotif users will stop hating us. :D
Comment 8 Nemo 2014-06-19 21:10:34 UTC 
*** Bug 66335 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links