Last modified: 2012-07-01 16:32:56 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T34372, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 32372 - Wikieditor toolbar has only a half of screen width


Summary:	Wikieditor toolbar has only a half of screen width

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	ProofreadPage (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal enhancement with 1 vote (vote)
Target Milestone:	---
Assigned To:	Zaran

URL:
Whiteboard:
Keywords:	patch, patch-need-review

Depends on:
Blocks:	Wikisource
	Show dependency tree / graph

Reported:	2011-11-12 07:58 UTC by Beau
Modified:	2012-07-01 16:32 UTC (History)
CC List:	4 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Patch fixing the reported issue (7.55 KB, patch) 2011-11-12 07:58 UTC, Beau	Details
Screenshot of current version (57.07 KB, image/png) 2011-11-12 07:59 UTC, Beau	Details
Screenshot of a new version (20.23 KB, image/png) 2011-11-12 08:00 UTC, Beau	Details
Add an attachment (proposed patch, testcase, etc.)

Description Beau 2011-11-12 07:58:42 UTC

Created attachment 9425 [details]
Patch fixing the reported issue

When editing Page namespace the width of the toolbar is limited by Proofread extension, which wraps the editing area before toolbar is constructed. Proofread extension should be run after toolbar is ready.

Comment 1 Beau 2011-11-12 07:59:42 UTC

Created attachment 9426 [details]
Screenshot of current version

Comment 2 Beau 2011-11-12 08:00:45 UTC

Created attachment 9427 [details]
Screenshot of a new version

Comment 3 Zaran 2012-01-23 01:53:53 UTC

What about users using horizontal mode (when the image is over the edit box). Should the toolbar be over the image or between the image and the edit box?

Comment 4 Beau 2012-01-27 17:14:53 UTC

I think it should be between the image and the edit box, so proofread+my patch works like that right now.

Comment 5 Beau 2012-04-11 11:36:13 UTC

I have submitted change I34fc8565383cde80be70211b97acd09c2ca923d5 for review.

Comment 6 Sumana Harihareswara 2012-05-25 03:27:57 UTC

For easier followup, here's a link: https://gerrit.wikimedia.org/r/#/c/4694/

Comment 7 Candalua 2012-05-25 20:42:39 UTC

Please, when will this be deployed? This is a very useful enhancement, and according to Beau it also fixes bug 36229 which is presently blocking some users completely.

Comment 8 Sumana Harihareswara 2012-05-26 14:26:28 UTC

Candalua, I've asked several people for help in reviewing this revision -- hope that helps.

Comment 9 Beau 2012-07-01 16:32:56 UTC

The change has been merged.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links