Last modified: 2012-07-01 16:40:07 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T38229, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 36229 - Proofread toolbar disappear occasionally
Proofread toolbar disappear occasionally
Product: MediaWiki extensions
Classification: Unclassified
ProofreadPage (Other open bugs)
All All
: High major with 2 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
Depends on:
Blocks: Wikisource
  Show dependency treegraph
Reported: 2012-04-25 07:21 UTC by vssun
Modified: 2012-07-01 16:40 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Screenshot of en.wikisource without proofreading toolbar (185.86 KB, image/png)
2012-04-25 07:21 UTC, vssun

Description vssun 2012-04-25 07:21:11 UTC
Created attachment 10464 [details]
Screenshot of en.wikisource without proofreading toolbar

When editing a page, the proofreading toolbar does not appear occasionally. It will appear again if refresh the page once or twice. 

I experienced this problem in ml.wikisource and en.wikisource projects of WMF.
Comment 1 Mark A. Hershberger 2012-04-25 15:35:25 UTC
Is this a regression? Did this problem only show up once 1.20wmf1 was put into production?
Comment 2 Beau 2012-04-25 15:47:54 UTC
I think this is a race condition caused by asynchronous script loading by ResourceLoader. IIRC asynchronous script loading was introduced in MW 1.19.

There are similar reports: bug 23479 and bug 28563.
Comment 3 vssun 2012-04-25 16:18:51 UTC
I started to experience this problem from April 18. 

Before that, a mini toolset was visible on the top-left corner of the page image, when the toolbar was not present.
Comment 4 Beau 2012-04-25 18:44:23 UTC
I think my fix for bug 32372 - Gerrit change #4694 resolves this issue too. It tries to load proofread extension code always after the toolbar has been constructed.
Comment 5 Candalua 2012-05-19 08:49:03 UTC
Please, when will this be fixed? Some visually impaired users are not able to do anything at all without the toolbar and the zoom/layout buttons, so I'm raising importance to "high".
Comment 6 OrbiliusMagister 2012-05-20 15:34:19 UTC
Please, many users rely on that toolbar to proofread properly: fix this bug, ASAP.
Comment 7 Alessandro Brollo 2012-05-21 08:12:52 UTC
Please fix the bug, but please take a big efford to simplify deeply all the ResourceLoader stuff. I feel that "toolbar object" is really too much complex to edit; it would need much more documentation and examples; but this is an "old" issue.
Comment 8 Beau 2012-05-21 08:27:47 UTC
The fix is ready since last November, however there is no one to review and merge the change.
Comment 9 vssun 2012-05-29 08:00:34 UTC
I am not experiencing this problem for last two days. Is there any fix is applied? What about others?
Comment 10 vssun 2012-05-29 08:25:31 UTC
Withdrawing the above comment. Problem still exists.
Comment 11 Beau 2012-07-01 16:40:07 UTC
Marking as fixed, since the patch for bug 32372 was merged. Please reopen if the issue still exists (check after the code was deployed on wmf sites).

Note You need to log in before you can comment on or make changes to this bug.