Last modified: 2012-09-27 01:11:03 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T33505, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 31505 - The title attribute of interwiki links is missing in Monobook/Vector/Modern skins
The title attribute of interwiki links is missing in Monobook/Vector/Modern s...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
1.18.x
All All
: Normal minor (vote)
: ---
Assigned To: Nobody - You can work on this!
: need-integration-test
: 31698 (view as bug list)
Depends on:
Blocks: 29876 32332
  Show dependency tree / graph
 
Reported: 2011-10-07 21:36 UTC by V111P
Modified: 2012-09-27 01:11 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Keep the title attributes (820 bytes, patch)
2011-10-09 17:59 UTC, Derk-Jan Hartman 		Details
Another patch that changes the approach for title forwarding (1.55 KB, patch)
2011-10-09 18:01 UTC, Derk-Jan Hartman 		Details
Add an attachment (proposed patch, testcase, etc.)

Description V111P 2011-10-07 21:36:14 UTC 
The interwiki links in the languages sidebar used to have title attributes (containing the name of the article in the other wiki), but now they are missing in Monobook, Vector and other skins.

The title attributes are still there in the Cologne Blue skin.
Comment 1 Derk-Jan Hartman 2011-10-09 17:59:08 UTC 
Created attachment 9201 [details]
Keep the title attributes

Confirmed, the new portlet linkbuilder was destroying 'title' attributes on links. This was not that visible, since most titles (and accesskeys) are actually generated on the fly based on element id.

Whitelisting the title attribute in makeListItem() and makeLink() of includes/SkinTemplate.php does the trick
Comment 2 Derk-Jan Hartman 2011-10-09 18:01:20 UTC 
Created attachment 9202 [details]
Another patch that changes the approach for title forwarding

I actually think that whitelisting link attributes here is a bad idea. The reason is that some of the attributes need  to be passed to one element, and some other elements to the wrapper element.

I think that an approach of explicit overriding an explicit removing of attributes (blacklist) is a better approach in that case. General idea in the patch, though probably should get a little more TLC.
Comment 3 Derk-Jan Hartman 2011-10-09 21:54:04 UTC 
Fixed by r99369
Comment 4 Phillip Patriakeas 2011-10-15 03:42:20 UTC 
*** Bug 31698 has been marked as a duplicate of this bug. ***
Comment 5 Mark A. Hershberger 2011-10-15 22:03:00 UTC 
tagging bugs for Marcus to look at
Comment 6 Daniel Friesen 2011-11-09 21:46:27 UTC 
Backported to 1.18 in r102522.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links