Last modified: 2012-09-27 01:11:10 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T33409, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 31409 - Arrow-down-icon in Vector no longer centered in 1.18
Arrow-down-icon in Vector no longer centered in 1.18
Status: RESOLVED INVALID
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
1.18.x
All All
: Low normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: need-integration-test, patch
Depends on:
Blocks: 29876
  Show dependency treegraph
 
Reported: 2011-10-06 04:54 UTC by Mark A. Hershberger
Modified: 2012-09-27 01:11 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Updated arrow-down-icon; shifted both icons one pixel to the right. (233 bytes, image/png)
2011-10-06 14:54 UTC, Erwin Dokter
Details
Blown-up screenshot showing off-center arrow (2.01 KB, image/png)
2011-10-06 18:42 UTC, Erwin Dokter
Details
Updated arrow-down-icon; shifted both icons one pixel to the right. (241 bytes, image/png)
2011-10-09 16:48 UTC, Erwin Dokter
Details
Updated arrow-down-icon; shifted icon one pixel to the right. (188 bytes, image/png)
2011-10-16 08:51 UTC, Erwin Dokter
Details
Updated arrow-down-focus-icon; shifted icon one pixel to the right (191 bytes, image/png)
2011-10-16 08:54 UTC, Erwin Dokter
Details

Description Mark A. Hershberger 2011-10-06 04:54:44 UTC
From [[WP:VPT]]: The down arrow on top of the drop down menu (in Vector) is one pixel off (to the left). The arrow icon has been changed to enable highlighting, but some CSS may not have been updated.
Comment 1 Erwin Dokter 2011-10-06 08:04:34 UTC
I will post a CSS patch or updated image.
Comment 2 Erwin Dokter 2011-10-06 14:54:30 UTC
Created attachment 9174 [details]
Updated arrow-down-icon; shifted both icons one pixel to the right.

Here's the new icon-down-arrow.png with both icons shifted one pixel to the right. Pallette preserved (still 4bbp) and lost 8 bytes of weight.
Comment 3 Brion Vibber 2011-10-06 18:26:35 UTC
Not sure I understand -- in what way is it off and what does shifting it to the right accomplish? I don't see any obvious inconsistencies poking at the arrow live.
Comment 4 Erwin Dokter 2011-10-06 18:42:43 UTC
Created attachment 9177 [details]
Blown-up screenshot showing off-center arrow

Granted, you'd need a looking glass to see the difference, but the arrow is not perfectly centered as it was in 1.17; it is now off-center to the left by one pixel. The new image will resolve that.
Comment 5 Erwin Dokter 2011-10-09 16:48:50 UTC
Created attachment 9199 [details]
Updated arrow-down-icon; shifted both icons one pixel to the right.

Fixed pallette.
Comment 6 Helder 2011-10-13 17:00:17 UTC
Just to be sure, have you tested this with the recent fix for bug 31396? (r99080, r99081, r99087)
Comment 7 Erwin Dokter 2011-10-13 19:46:17 UTC
No, but I'm sure I won't have to; the attached file *will* regress bug 31396 (the image has been split up there). However, r99080 *may* also fix the off-center issue, making this bug moot, but I have no way of testing.
Comment 8 Mark A. Hershberger 2011-10-15 22:03:35 UTC
tagging bugs for Marcus to look at
Comment 9 Erwin Dokter 2011-10-16 08:51:45 UTC
Created attachment 9241 [details]
Updated arrow-down-icon; shifted icon one pixel to the right.
Comment 10 Erwin Dokter 2011-10-16 08:54:21 UTC
Created attachment 9242 [details]
Updated arrow-down-focus-icon; shifted icon one pixel to the right

Since the sprite image was updated to two seperate images, I have updated those images to shift both icons 1 pixel to the right. There should be no regression.
Comment 11 Erwin Dokter 2011-10-16 09:02:40 UTC
Closing; As it turns out, the associated CSS changes made in r99080 also fixes the off-center issue.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links