Last modified: 2012-04-19 21:22:19 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T33396, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 31396 - Background image of vectorTabs overlaps with the variant name


Summary:	Background image of vectorTabs overlaps with the variant name

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	Language converter (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Unprioritized normal (vote)
Target Milestone:	1.18.0 release
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	29068
	Show dependency tree / graph

Reported:	2011-10-05 22:12 UTC by Helder
Modified:	2012-04-19 21:22 UTC (History)
CC List:	4 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
The icon is in the wrong place, and is displayed two times (19.49 KB, image/png) 2011-10-05 22:13 UTC, Helder	Details
Add an attachment (proposed patch, testcase, etc.)

Description Helder 2011-10-05 22:12:00 UTC

Set the following values on your LocalSettings:
$wgLanguageCode = "zh";
$wgVectorShowVariantName = true;

This will make MediaWiki to display the name of the current variant above the menu.

On MediaWiki 1.17, there was an arrow to the right of the variant name, but on MediaWiki 1.18 this was changed to a double arrow which overlaps with the variant name.

See the attached screenshot.

Comment 1 Helder 2011-10-05 22:13:22 UTC

Created attachment 9165 [details]
The icon is in the wrong place, and is displayed two times

Comment 2 Helder 2011-10-05 22:15:57 UTC

FYI: The images in question are the following:
* https://bits.wikimedia.org/skins-1.17/vector/images/arrow-down-icon.png
* https://bits.wikimedia.org/skins-1.18/vector/images/arrow-down-icon.png

The second one has two arrows and is wrongly positioned on MW 1.18 under the  configuration mentioned on comment 0.

Comment 3 Krinkle 2011-10-05 22:23:08 UTC

Here is the CSS related to that icon as of MediaWiki 1.19:

	/* @noflip */
	div.vectorMenu {
		direction: ltr;
		float: left;
		/* @embed */
		background-image: url(images/arrow-down-icon.png);
		background-position: 0px 60%;
		background-repeat: no-repeat;
		cursor: pointer;
	}
	div.vectorMenuFocus {
		background-position: -22px 60%;
	}

The cause seems to be in alignment of the sprite.
I can't reproduce this bug, but if it's still happening in trunk:
* Don't use sprites
* @noflip for the other one rule too

Comment 4 Helder 2011-10-05 22:29:14 UTC

(In reply to comment #3)
> I can't reproduce this bug, but if it's still happening in trunk:

I just tested it using trunk version of MediaWiki and still happens as described when $wgLanguageCode = "zh" and $wgVectorShowVariantName = true;.

Comment 5 Philip Tzou 2011-10-06 09:46:37 UTC

r99080 may fix it.

Comment 6 Helder 2011-10-10 12:33:51 UTC

(In reply to comment #5)
> r99080 may fix it.

Thanks!
I'm adding bug 29068 because the broken CSS is deployed on Wikimedia wikis affecting pages like this:
https://en.wikisource.org/wiki/pt:Elementos_de_Arithmetica/Cap%C3%ADtulo_1

Comment 7 Robin Pepermans (SPQRobin) 2011-10-10 15:41:30 UTC

I had already reported this on bug 20193 but I probably should've opened a new one..

Comment 8 Erwin Dokter 2011-10-13 20:02:46 UTC

With the deployment of 1.18, the arrow in the p-cactions menu is also slightly off-center to the left (see bug 31409). Can someone see if that has been resolved by this fix? In that case I can close 31409 as well.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links