Last modified: 2011-10-11 10:45:10 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T32770, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 30770 - "Timeline error" - improved wording and directionality [PATCH]


Summary:	"Timeline error" - improved wording and directionality [PATCH]

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	EasyTimeline (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Unprioritized normal (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:	patch, patch-need-review

Depends on:
Blocks:	rtl
	Show dependency tree / graph

Reported:	2011-09-05 18:50 UTC by Amir E. Aharoni
Modified:	2011-10-11 10:45 UTC (History)
CC List:	1 user (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Removed "Executable not found" and added dir="ltr" to an error message. (503 bytes, patch) 2011-09-05 18:50 UTC, Amir E. Aharoni	Details
Add an attachment (proposed patch, testcase, etc.)

Description Amir E. Aharoni 2011-09-05 18:50:01 UTC

Created attachment 9016 [details]
Removed "Executable not found" and added dir="ltr" to an error message.

I made two changes to the error message in Timeline.php:

1. Removed "Executable not found". It is not necessarily correct - the executable is EasyTimeline.pl and this message can be produced if it is found but didn't run expected.

2. Added dir="ltr". It can appear in an RTL wiki, but it's always in English (which is OK), so it LTR direction should be forced.

Comment 1 Amir E. Aharoni 2011-10-11 10:45:10 UTC

Fixed in r99471.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links