Last modified: 2011-06-14 20:22:27 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T31291, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 29291 - The transcode status table is added regardless of whether or not you have a transcoder installed
The transcode status table is added regardless of whether or not you have a t...
Status: RESOLVED FIXED
Product: mwEmbed
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Michael Dale
:
Depends on:
Blocks: 27699
  Show dependency treegraph
 
Reported: 2011-06-06 20:31 UTC by Derk-Jan Hartman
Modified: 2011-06-14 20:22 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
screenshot of instantcommons video file. (24.98 KB, image/png)
2011-06-06 23:02 UTC, Derk-Jan Hartman
Details

Description Derk-Jan Hartman 2011-06-06 20:31:09 UTC
I get this table, but i have no intention of ever installing transcoding on my local machine. We might want to hide it, when it isn't actually doing anything.
Comment 1 Michael Dale 2011-06-06 21:11:39 UTC
So hide the transcode status table on shared repo assets? and or add a local configuration variable that lets you disable transcoding all together so we don't add the transcode jobs and we don't check the transcode table when rendering sources. 

I guess we should do both. ( done in r89609 )
Comment 2 Derk-Jan Hartman 2011-06-06 23:01:44 UTC
Almost... 

See attachment for remote file.
Comment 3 Derk-Jan Hartman 2011-06-06 23:02:12 UTC
Created attachment 8629 [details]
screenshot of instantcommons video file.
Comment 4 Derk-Jan Hartman 2011-06-06 23:03:11 UTC
and:


Notice: Undefined index: Folgers.ogv in /Users/hartman/Development/wiki-extensions/TimedMediaHandler/WebVideoTranscode/WebVideoTranscode.php on line 390

Warning: Invalid argument supplied for foreach() in /Users/hartman/Development/wiki-extensions/TimedMediaHandler/TranscodeStatusTable.php on line 44
Comment 5 Michael Dale 2011-06-07 15:57:14 UTC
hmm did you svn update and action=purge the page? 

For example the "Notice: Undefined index:" seems like it would not occur if we set self::$transcodeState[ $fileName ] = array(); right above that line. see @@ -370,6 +372,8 @@ in r89609
Comment 6 Michael Dale 2011-06-14 20:22:27 UTC
In chatting with Derk-Jan Hartman over IRC this fixed for him now. 

There was some concern about the database tables being around even if transcoding is off, but its not easy to support switching the transcode option on and off if we remove these tables, so we will leave them in there. If transcoding is off no transcodes take place and no files pages will show the transcode table.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links