Last modified: 2011-06-24 17:11:36 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T29593, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 27593 - API should return error message when sha1/sha1base36 is invalid
API should return error message when sha1/sha1base36 is invalid
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
API (Other open bugs)
1.18.x
All All
: Normal enhancement (vote)
: ---
Assigned To: Roan Kattouw
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2011-02-20 20:24 UTC by db [inactive,noenotif]
Modified: 2011-06-24 17:11 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description db [inactive,noenotif] 2011-02-20 20:24:42 UTC 
Using a invalid sha1 value for list=allimages/list=filearchive returns all files.

Using a invalid sha1base36 returns nothing.

In my opinion a error message is good, or let a invalid sha1 return nothing.

Thanks.
Comment 1 Sam Reed (reedy) 2011-05-08 21:48:45 UTC 
"Invalid" can only be defined by it not being the correct length, right?
Comment 2 Bryan Tong Minh 2011-05-09 07:31:15 UTC 
Well, they should contain only 0-f or 0-z respectively.
Comment 3 Sam Reed (reedy) 2011-05-09 15:10:40 UTC 
0-f and 0-z

Surely it's 0123456789abcdef?

I suppose a length check, and then check for a char that doesn't match those...
Comment 4 Sam Reed (reedy) 2011-05-15 13:16:57 UTC 
Right, so sha1 are hex, but base36 is 0-9a-z like you say


filearchive doesn't allow you to specify a SHA1 hash to filter by.. Just output

r88174
Comment 5 db [inactive,noenotif] 2011-05-15 14:47:06 UTC 
(In reply to comment #4)
> filearchive doesn't allow you to specify a SHA1 hash to filter by.. Just output

Because bug 21346 was reverted after written of this bug
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links